Mir

Merge lp://qastaging/~vanvugt/mir/fix-1277343 into lp://qastaging/mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 1405
Proposed branch: lp://qastaging/~vanvugt/mir/fix-1277343
Merge into: lp://qastaging/mir
Diff against target: 40 lines (+9/-0)
2 files modified
src/client/mir_connection.cpp (+1/-0)
tests/unit-tests/client/test_mir_connection.cpp (+8/-0)
To merge this branch: bzr merge lp://qastaging/~vanvugt/mir/fix-1277343
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Alexandros Frantzis (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Daniel van Vugt Abstain
Review via email: mp+206671@code.qastaging.launchpad.net

Commit message

Remember to set field "current_format" when sending a display config to the
server. Until now it had been left uninitialized, which resulted in an
invalid display config on the server (LP: #1277343)

A test case did exist for this kind of thing, but the test case itself was
buggy and never updated to check the relatively new field "current_format".

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Mixed up current_mode/format in test case.

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Abstain
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches