Mir

Merge lp://qastaging/~vanvugt/mir/fix-1348467 into lp://qastaging/mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 1797
Proposed branch: lp://qastaging/~vanvugt/mir/fix-1348467
Merge into: lp://qastaging/mir
Diff against target: 12 lines (+1/-1)
1 file modified
3rd_party/android-input/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp://qastaging/~vanvugt/mir/fix-1348467
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) Approve
Alan Griffiths Approve
Review via email: mp+228234@code.qastaging.launchpad.net

Commit message

Hide -Wformat compiler warnings from the android-input code. (LP: #1348467)

We don't care to fix Google's log messages.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Having forked we should adapt the code to our standards. But I agree this is low on the priority list.

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

looks good, glad to see the spew disappear.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches