Mir

Merge lp://qastaging/~vanvugt/mir/fix-1581368 into lp://qastaging/mir

  1. fix-1581368
  2. Merge into development-branch
Proposed by Daniel van Vugt
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 3512
Proposed branch: lp://qastaging/~vanvugt/mir/fix-1581368
Merge into: lp://qastaging/mir
Diff against target: 172 lines (+88/-6)
4 files modified
src/client/buffer_stream.cpp (+3/-2)
src/client/periodic_perf_report.cpp (+7/-1)
tests/acceptance-tests/test_client_logging.cpp (+26/-3)
tests/unit-tests/client/test_client_buffer_stream.cpp (+52/-0)
To merge this branch: bzr merge lp://qastaging/~vanvugt/mir/fix-1581368
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve
Kevin DuBois (community) Approve
Cemil Azizoglu (community) Approve
Review via email: mp+294893@code.qastaging.launchpad.net

Commit message

Fix client perf report render times and buffer lag going off the
scale after things moved around recently (LP: #1581368)

Description of the change

The fix is tiny but the enhancements to the tests much bigger.

To post a comment you must log in.
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Ok

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

nit:
+ (void)bs.get_current_buffer();
needed?

lgtm

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yes, get_current_buffer() indicates the start of a frame being rendered so that's where the perf report calls begin_frame. There's (no longer) anywhere else to hook in begin_frame, is there?

Revision history for this message
Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches