Mir

Merge lp://qastaging/~vanvugt/mir/resize-client-buffers into lp://qastaging/mir

  1. resize-client-buffers
  2. Merge into development-branch
Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 1221
Proposed branch: lp://qastaging/~vanvugt/mir/resize-client-buffers
Merge into: lp://qastaging/mir
Prerequisite: lp://qastaging/~vanvugt/mir/resize-protocol
Diff against target: 151 lines (+50/-7)
6 files modified
src/client/android/android_client_buffer_factory.cpp (+7/-1)
src/client/gbm/gbm_client_buffer_factory.cpp (+6/-1)
tests/integration-tests/client/test_client_render.cpp (+9/-0)
tests/unit-tests/client/gbm/test_gbm_client_buffer.cpp (+21/-0)
tests/unit-tests/client/test_android_client_buffer_factory.cpp (+5/-5)
tests/unit-tests/client/test_client_mir_surface.cpp (+2/-0)
To merge this branch: bzr merge lp://qastaging/~vanvugt/mir/resize-client-buffers
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
Alan Griffiths Approve
Review via email: mp+194825@code.qastaging.launchpad.net

Commit message

Add resize support to *ClientBuffer classes. Now always get dimensions from
the latest buffer package.

Description of the change

There are some comments about some "size" parameters now being unused. They will be eliminated in later proposals.

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I'd like to see the unused parameters gone, but OK as an intermediate step.

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

good improvement after the resize protocol changes

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The unused "size" parameters... I started removing and found the resulting diff from that cleanup work to be much bigger that this proposal. And it's only this one that contains the useful functionality change.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches