Mir

Merge lp://qastaging/~vanvugt/mir/resize-examples into lp://qastaging/mir

  1. resize-examples
  2. Merge into development-branch
Proposed by Daniel van Vugt
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 1232
Proposed branch: lp://qastaging/~vanvugt/mir/resize-examples
Merge into: lp://qastaging/mir
Prerequisite: lp://qastaging/~vanvugt/mir/resize-client-buffers
Diff against target: 290 lines (+127/-20)
4 files modified
examples/demo-shell/window_manager.cpp (+102/-14)
examples/demo-shell/window_manager.h (+6/-2)
examples/eglapp.c (+10/-0)
examples/progressbar.c (+9/-4)
To merge this branch: bzr merge lp://qastaging/~vanvugt/mir/resize-examples
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) testing Approve
Alan Griffiths Approve
Review via email: mp+194833@code.qastaging.launchpad.net

Commit message

Add resizing support to example code; demo-shell and clients.

Description of the change

Touch: 3-fingers to pinch/zoom/drag
Desktop: Alt+LeftButton to move, Alt+MiddleButton to resize.
It's slightly kludgy but a good starting point for manual testing.

Please note; this is not resizing complete. What's missing is:
1. Mesa EGL surface resize support (a proof of concept patch is attached to the bug).
2. Resize events (this is why some clients seem laggy in resizing, because they're still only polling and sleeping).

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I assume the broken display I see when attempting resizing is due the the Mesa issue mentioned?

Otherwise, the code looks sane.

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1227
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/372/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/176
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/173
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/101
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/101/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/101
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/101/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-team-mir-development-branch-ci/372/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yes, Mesa surfaces will look broken under resize without the patch.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

In fact, don't stress an unpatched Mesa too much. It will get into a bad state and you may have to reboot :(

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

ok

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

looks good on the nexus 10

review: Approve (testing)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-autolanding/154/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/202/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/199
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-autolanding/57
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-autolanding/57/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-autolanding/57
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-autolanding/57/artifact/work/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches