lp://qastaging/~vanvugt/mir/simple-connect

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://qastaging/~mir-team/mir/trunk

Alan Griffiths: Disapprove on 2013-03-07

Robert Carr (community): Abstain on 2013-02-25

PS Jenkins bot (community): Approve (continuous-integration) on 2013-02-08

Diff: 319 lines (+149/-19)

10 files modified

examples/demo_client.c (+2/-7)
include/mir_client/mir_client_library.h (+15/-0)
src/client/mir_client_library.cpp (+12/-1)
src/client/mir_connection.cpp (+3/-2)
src/client/mir_wait_handle.cpp (+6/-4)
src/client/mir_wait_handle.h (+3/-2)
tests/acceptance-tests/test_client_library.cpp (+45/-1)
tests/unit-tests/client/CMakeLists.txt (+1/-0)
tests/unit-tests/client/test_mir_connection.cpp (+24/-2)
tests/unit-tests/client/test_wait.cpp (+38/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1112195: Mir client API lacks simple synchronous interface

High

Fix Released

Link a bug report

Related blueprints

410. By Daniel van Vugt on 2013-02-08

Demonstrate two ways of avoiding callbacks in the client API:
  1. conn = mir_wait_for_connection(mir_connect(...));
  2. conn = mir_wait_connect(...);

I was trying to avoid the redundancy of having multiple functions per
operation in my previous proposal. However since that was disapproved, this
is the next best thing.

Arguably, we don't need mir_wait_connect() because it's just shorthand for:
  conn = mir_wait_for_connection(mir_connect(server, app, nullptr, nullptr));

And even then, we don't need mir_wait_for_connection(). I just added it to
keep the purists happy and avoid the weakly typed alternative:
  conn = (MirConnection*)mir_wait_for(mir_connect(...));

409. By Alan Griffiths on 2013-02-07

protobuf, tests: Use correct headers for mutex & condition_variable.

Approved by Alexandros Frantzis, PS Jenkins bot.

408. By Alan Griffiths on 2013-02-07

3rd_party/android-input: tests and fixes for String8 formatting functions.

Approved by PS Jenkins bot, Alexandros Frantzis.

407. By Alan Griffiths on 2013-02-06

3rd_party/android-input: remove reliance on hardware_legacy/power.(c|h).

Approved by Alexandros Frantzis, PS Jenkins bot.

406. By Alan Griffiths on 2013-02-06

3rd_party/android-input: remove reliance on cutils/atomic.(c|h).

Approved by Alexandros Frantzis, PS Jenkins bot.

405. By Alan Griffiths on 2013-02-06

3rd_party/android-input: move the files we want to keep to "input".

Approved by Thomas Voß, PS Jenkins bot.

404. By Kevin DuBois on 2013-02-06

remove the wrappers for <thread> and <chrono> that were used to work around poor stdlib support on android, now that we have proper support of these libraries in the chroot.

Approved by Alan Griffiths, PS Jenkins bot.

403. By Alan Griffiths on 2013-02-05

graphics: Silence "narrowing conversion" with g++ 4.7.

Approved by PS Jenkins bot, Kevin DuBois.

402. By Kevin DuBois on 2013-02-05

stride was not being put into the native window type correctly. This caused render glitches when client was rendering. Add test that catches this condition

fixes: bug #1111612. Fixes: https://bugs.launchpad.net/bugs/1111612.

Approved by Alexandros Frantzis, Robert Carr, PS Jenkins bot, Alan Griffiths.

401. By Alan Griffiths on 2013-02-05

various: An assortment of nitpicky tidy-up.

Approved by Alexandros Frantzis, PS Jenkins bot.