Merge lp://qastaging/~vanvugt/totem/fix-1698282 into lp://qastaging/~ubuntu-desktop/totem/ubuntu
Proposed by
Daniel van Vugt
| Status: | Merged |
|---|---|
| Merged at revision: | 258 |
| Proposed branch: | lp://qastaging/~vanvugt/totem/fix-1698282 |
| Merge into: | lp://qastaging/~ubuntu-desktop/totem/ubuntu |
| Diff against target: |
69 lines (+49/-0) 3 files modified
debian/changelog (+7/-0) debian/patches/fix-bvw_update_tags-performance.patch (+41/-0) debian/patches/series (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~vanvugt/totem/fix-1698282 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sebastien Bacher | Approve | ||
| Ubuntu Sponsors | Pending | ||
|
Review via email:
|
|||
Commit message
Reduce CPU usage and stuttery playback
For some reason bvw_update_tags gets called constantly even when none are
changing. And each call seems to trigger a clutter scene graph update.
So totem was spending 20-25% of its time in g_signal_emit and below updating the clutter scene graph and GTK widgets. With this fix, totem's
CPU usage drops by about a fifth and playback is much smoother (although
still not perfect).
This fixes the totem portion of LP: #1698282 and LP: #1698270, although
both bugs also need work done in clutter before they can be declared fully
resolved.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks Daniel