Code review comment for lp://qastaging/~vanvugt/ubuntu/raring/ubuntu-settings/fix-1073202

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

On Tue, Nov 27, 2012 at 10:44 PM, Didier Roche <email address hidden> wrote:
> Review: Needs Fixing
>
> So, as said on IRC, this fix will trigger a lot of other side effects.

For those of us who weren't on IRC, can you discuss what those side
effects were?

>
> The real bug is what I explained here: https://bugs.launchpad.net/compiz/+bug/1073202/comments/1, which is a compiz issue.
>
> I'm afraid that we never get to the bottom of this bug (and so the other settings won't be migrated) if we go this way. Then, I'm happy to sync this setting. But some people like pitti are still impacted by this bug (the "compiz doesn't copy the integrated settings the first time I log in, but just on some configuration")

Can you elaborate?

The fact that we have the /wrong value/ set for the gsettings key that
the tests need to read gives a pretty good indication as to why they
fail. Why would compiz looking at its own keys have anything to do
with those tests failing, especially when its own key is actually the
correct one in this circumstance.

>
> Sam, you told some weeks ago that you knew what was causing this? do you know more about it?
> --
> https://code.launchpad.net/~vanvugt/ubuntu/raring/ubuntu-settings/fix-1073202/+merge/134424
> You are reviewing the proposed merge of lp:~vanvugt/ubuntu/raring/ubuntu-settings/fix-1073202 into lp:ubuntu/ubuntu-settings.

--
Sam Spilsbury

« Back to merge proposal