Merge lp://qastaging/~vanvugt/unity/fix-687567-unity3.0 into lp://qastaging/unity/3.0
Proposed by
Daniel van Vugt
| Status: | Merged |
|---|---|
| Merged at revision: | 1207 |
| Proposed branch: | lp://qastaging/~vanvugt/unity/fix-687567-unity3.0 |
| Merge into: | lp://qastaging/unity/3.0 |
| Diff against target: |
146 lines (+37/-66) 1 file modified
services/panel-service.c (+37/-66) |
| To merge this branch: | bzr merge lp://qastaging/~vanvugt/unity/fix-687567-unity3.0 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neil J. Patel (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fix white "flashes" seen in the panel menus during scrubbing, or when they're unmapped (LP: #687567)
The problem, it seems, was that we were calling gdk/gtk/X11 functions in the middle of a GDK event filter. Removing these function calls and replacing them with a simpler, more optimized solution solves the problem.
I'm proposing this fix to unity 3.0 first because it was developed and tested on natty. I will forward port it to unity trunk (requires some conflict resolution) after this version has been approved.
To post a comment you must log in.
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
Revision history for this message
| Neil J. Patel (njpatel) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
And before someone suggests the bug was a timing issue, it wasn't. I tried inserting delays in the affected code and it made no difference. Only removing the gdk/gtk/X calls fixed the problem.