Merge lp://qastaging/~vanvugt/unity/fix-761465 into lp://qastaging/unity
Proposed by
Daniel van Vugt
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Gord Allott | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 1273 | ||||
| Proposed branch: | lp://qastaging/~vanvugt/unity/fix-761465 | ||||
| Merge into: | lp://qastaging/unity | ||||
| Diff against target: |
39 lines (+6/-4) 2 files modified
plugins/unityshell/src/PlacesSimpleTile.cpp (+5/-4) plugins/unityshell/src/PlacesSimpleTile.h (+1/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~vanvugt/unity/fix-761465 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gord Allott (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Make icon highlight box the same size (maximum) for all icons in the dash (LP: #761465)
Note that this fix addresses the problem with the size and position of the highlight box. The correctness of the icon size itself is still arguable, but that can be addressed/discussed as a separate enhancement or bug, if at all.
To post a comment you must log in.
Revision history for this message
| Marco Biscaro (marcobiscaro2112) wrote | # |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice work!
Just one thing: I think you should use _ideal_icon_size instead of _idealiconsize.
Apart from that, +1.