Unity

Merge lp://qastaging/~vanvugt/unity/fix-773892 into lp://qastaging/unity

  1. fix-773892
  2. Merge into trunk
Proposed by Daniel van Vugt
Status: Superseded
Proposed branch: lp://qastaging/~vanvugt/unity/fix-773892
Merge into: lp://qastaging/unity
Diff against target: 257 lines (+108/-11)
6 files modified
plugins/unityshell/src/Launcher.cpp (+52/-6)
plugins/unityshell/src/Launcher.h (+7/-1)
plugins/unityshell/src/PlacesController.cpp (+30/-0)
plugins/unityshell/src/PlacesController.h (+3/-1)
plugins/unityshell/src/PlacesSimpleTile.cpp (+12/-3)
plugins/unityshell/src/UBusMessages.h (+4/-0)
To merge this branch: bzr merge lp://qastaging/~vanvugt/unity/fix-773892
Reviewer Review Type Date Requested Status
Gord Allott Pending
Review via email: mp+70984@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-07-07.

Description of the change

Keep dash open while dragging apps into the launcher (LP: #773892)

Old behaviour: The dash closes as soon as you start dragging any icon from the dash.

New behaviour: The dash stays open if you're dragging an application icon. This allows you to quickly drag several apps into the launcher. If it's not an app (usually a file) then the dash reverts to the old behaviour and closes as soon as you start dragging.

I think the new behaviour makes for a much more pleasant, and less frustrating, user experience.

IMPORTANT NOTE: This fix exposes Nux bug 805874. Ideally you should have the fix for bug 805874 (merge pending) before testing this fix. Otherwise it will look buggy.

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) wrote : Posted in a previous version of this proposal

Waiting for the nux branch

review: Abstain
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

Judging by Jay's comments, it sounds like the fix for nux bug 805874 won't be merged at all because it will be superseded. We may be waiting forever... ?

Revision history for this message
Gord Allott (gordallott) wrote : Posted in a previous version of this proposal

once the new input refactoring branch lands in Nux I'll take another look at this branch and see if it works without the bug you mentioned, its on my to do list don't worry :) if it doesn't work after that lands I'll let you know

Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

Jay says the new nux event architecture is released. Oneiric may not need a fix for bug 805874 any more. Please test this fix again...

Revision history for this message
Gord Allott (gordallott) wrote : Posted in a previous version of this proposal

lots of conflicts with trunk, so trying to merge in trunk with it failed more than i am comfortable with, so needs the conflicts fixing

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

Yes I noticed the extensive style and clean-up changes that happened in lp:unity recently. While it's great in theory it has caused me a bit a grief with conflicts. But such conflicts are hopefully only once-off.

I'll revisit and rebase this fix soon.

Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

Conflicts resolved.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(insert lots of swearing here)

I resolved the conflicts last week. Now I resubmit the proposal, new conflicts in lp:unity have appeared. :(

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.