Merge lp://qastaging/~vanvugt/unity/fix-805327 into lp://qastaging/unity

Proposed by Daniel van Vugt
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 1302
Proposed branch: lp://qastaging/~vanvugt/unity/fix-805327
Merge into: lp://qastaging/unity
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/unityshell/src/Launcher.cpp (+1/-1)
To merge this branch: bzr merge lp://qastaging/~vanvugt/unity/fix-805327
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+66749@code.qastaging.launchpad.net

Description of the change

Fixed dead code; expression was always zero. (LP: #805327)

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

On Mon, 04 Jul 2011 18:51:55 you wrote:
> Daniel van Vugt has proposed merging lp:~vanvugt/unity/fix-805327 into
> lp:unity.
>
> Requested reviews:
> Unity Team (unity-team)
>
> For more details, see:
> https://code.launchpad.net/~vanvugt/unity/fix-805327/+merge/66749
>
> Fixed dead code; expression was always zero. (LP: #805327)

That certainly looks more sensible. Do you know what it was impacting?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

No, I had not seen any symptoms. I'm not entirely sure the affected code is actually used.

So either this fix should be committed, or the affected code is unused and can be wholly removed. Not sure which.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.