Unity

Merge lp://qastaging/~vanvugt/unity/fix-822157-3.0 into lp://qastaging/unity/3.0

  1. fix-822157-3.0
  2. Merge into branch-3.0
Proposed by Daniel van Vugt
Status: Merged
Approved by: Neil J. Patel
Approved revision: no longer in the source branch.
Merged at revision: 1209
Proposed branch: lp://qastaging/~vanvugt/unity/fix-822157-3.0
Merge into: lp://qastaging/unity/3.0
Diff against target: 42 lines (+6/-1)
2 files modified
src/SimpleLauncherIcon.cpp (+5/-1)
src/SimpleLauncherIcon.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~vanvugt/unity/fix-822157-3.0
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Review via email: mp+70665@code.qastaging.launchpad.net

Description of the change

Fixed SimpleLauncherIcon::GetTextureForSize continuously reloading some icons on every redraw. Wasting lost of CPU. (LP: #822157)

An almost identical fix has already been committed to unity 4.4.0 (without a bug ID):
http://bazaar.launchpad.net/~unity-team/unity/trunk/revision/1296#plugins/unityshell/src/SimpleLauncherIcon.cpp

Since the fix provides a significant performance improvement with very little changes and almost no risk, I think it's worth proposing to unity 3.x.

To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) wrote :

Thanks!

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Please remember to nominate natty in bug 822157. Currently it only shows the status for oneiric.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: