openerp-mexico-localization

Merge lp://qastaging/~vauxoo/openerp-mexico-localization/sale_payment_method_dev_luis into lp://qastaging/openerp-mexico-localization

sale_payment_method_dev_luis
Merge into trunk

Proposed by Luis Torres - http://www.vauxoo.com on 2012-10-23

Status:	Rejected
Rejected by:	Moisés López - http://www.vauxoo.com on 2013-06-07
Proposed branch:	lp://qastaging/~vauxoo/openerp-mexico-localization/sale_payment_method_dev_luis
Merge into:	lp://qastaging/openerp-mexico-localization
Diff against target:	221 lines (+196/-0) 5 files modified l10n_mx_sale_payment_method/__init__.py (+27/-0) l10n_mx_sale_payment_method/__openerp__.py (+46/-0) l10n_mx_sale_payment_method/sale.py (+56/-0) l10n_mx_sale_payment_method/sale_view.xml (+17/-0) l10n_mx_sale_payment_method/stock.py (+50/-0)
To merge this branch:	bzr merge lp://qastaging/~vauxoo/openerp-mexico-localization/sale_payment_method_dev_luis
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Moisés López - http://www.vauxoo.com	2012-10-23	Disapprove on 2013-06-07
Luis Torres - http://www.vauxoo.com (community)		Needs Resubmitting on 2012-10-23
Rodolfo Lopez	2012-10-23	Pending
Isaac López Zúñiga	2012-10-23	Pending
Review via email: mp+131109@code.qastaging.launchpad.net

Description of the change

Se agregaron los campos del número de cuenta y el metodo de pago a la sale, estos los toma de los datos del cliente

Revision history for this message

Moisés López - http://www.vauxoo.com (moylop260) wrote on 2012-10-23:

Luis,

En esta línea va a marcar error cuando no tenga sale asociada.
+ sale_id = self.browse(cursor, user, picking_id, context=context).sale_id.id
Cambiar por
+ sale_obj = self.browse(cursor, user, picking_id, context=context)
+ sale_id = sale_obj.sale_id and sale_obj.sale_id.id or False

Los write los puedes mandar a un solo write, solo para que quede más eficiente.
219 + invoice_obj.write(cursor, user, [invoice_id], {'acc_payment': acc_payment_id}, context=context)
220 + invoice_obj.write(cursor, user, [invoice_id], {'pay_method_id': payment_method_id}, context=context)

Cambiar a
219 + invoice_obj.write(cursor, user, [invoice_id], {'acc_payment': acc_payment_id, 'pay_method_id': payment_method_id}, context=context)

lp://qastaging/~vauxoo/openerp-mexico-localization/sale_payment_method_dev_luis updated on 2012-10-23

209. By Luis Torres - http://www.vauxoo.com on 2012-10-23: [IMP][l10n_mx_sale_payment_method]Add a validation for False & improvement code

Revision history for this message

Luis Torres - http://www.vauxoo.com (luis-cleto-) wrote on 2012-10-23:

Se agrego una validacion para cuando no haya sale_order
y se recorto la linea de los write

review: Needs Resubmitting

Revision history for this message

Moisés López - http://www.vauxoo.com (moylop260) wrote on 2013-06-07:

mp applied in other mp

review: Disapprove

Unmerged revisions

209. By Luis Torres - http://www.vauxoo.com on 2012-10-23: [IMP][l10n_mx_sale_payment_method]Add a validation for False & improvement code
208. By Luis Torres - http://www.vauxoo.com on 2012-10-23: [ADD][l10n_mx_sale_payment_method]Add fields to acc_payment & payment_method in sale