Unity

Merge lp://qastaging/~vbkaisetsu/unity/bug957927 into lp://qastaging/unity

  1. bug957927
  2. Merge into trunk
Proposed by Koichi Akabe
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 2229
Proposed branch: lp://qastaging/~vbkaisetsu/unity/bug957927
Merge into: lp://qastaging/unity
Diff against target: 279 lines (+110/-27)
8 files modified
plugins/unityshell/src/DashView.cpp (+2/-2)
plugins/unityshell/src/HudView.cpp (+23/-25)
plugins/unityshell/src/HudView.h (+1/-0)
plugins/unityshell/src/IMTextEntry.cpp (+5/-0)
plugins/unityshell/src/IMTextEntry.h (+1/-0)
plugins/unityshell/src/SearchBar.cpp (+6/-0)
plugins/unityshell/src/SearchBar.h (+2/-0)
tests/autopilot/autopilot/tests/test_ibus.py (+70/-0)
To merge this branch: bzr merge lp://qastaging/~vbkaisetsu/unity/bug957927
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
Gord Allott (community) Approve
Alex Launi (community) Needs Fixing
Review via email: mp+98057@code.qastaging.launchpad.net

Commit message

Ensures hud ignores key presses once ibus is active

Description of the change

I fixed bug #957927
Please merge this branch.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Hi Koichi, thanks for your patch.
However, you need to sign the Canonical Contributor Agreement to get it merged.

Revision history for this message
Koichi Akabe (vbkaisetsu) wrote :

Hi,
Thank you for your information.
I sent the CCA on the internet just now.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ok, the agreement is there.
So, I guess we need to wait the nux branch to be merged.

Revision history for this message
Alex Launi (alexlauni) wrote :

This needs a test. It should be very simple to write an autopilot test to ensure that this does not regress. Please ping me, or anyone else on irc if you need help with autopilot testing.

review: Needs Fixing
Revision history for this message
Koichi Akabe (vbkaisetsu) wrote :

Hi Alex,
I added autopilot codes for ibus-anthy and ibus-pinyin. But I didn't add for ibus-hangul because it commits hangul on input components.

Please review it.

Revision history for this message
Gord Allott (gordallott) wrote :

+1 here

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

This needs to be merged with trunk, other than that it's fine.

Revision history for this message
Koichi Akabe (vbkaisetsu) wrote :

It has many changes, but I think it was merged correctly.

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Looks good to me. +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.