lp://qastaging/busybox

Created by Jelmer Vernooij and last modified
Get this branch:
bzr branch lp://qastaging/busybox

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
VCS imports
Project:
BusyBox
Status:
Development

Import details

Import Status: Suspended

This branch is an import of the HEAD branch of the Git repository at git://busybox.net/busybox.git.

Last successful import was .

Import started on juju-eb11dc-stg-qa-launchpad-codeimport-0 and finished taking 30 seconds — see the log
Import started on juju-eb11dc-stg-qa-launchpad-codeimport-0 and finished taking 25 seconds — see the log
Import started on juju-eb11dc-stg-qa-launchpad-codeimport-0 and finished taking 25 seconds — see the log
Import started on juju-eb11dc-stg-qa-launchpad-codeimport-0 and finished taking 30 seconds — see the log

Updating branch...

Launchpad is processing new changes to this branch which will be available in a few minutes. Reload to see the changes.

Recent revisions

17723. By Vda-linux

start-stop-daemon: make --output not depend on FANCY

Signed-off-by: Denys Vlasenko <email address hidden>

17722. By Vda-linux

start-stop-daemon: do not lose error messages with -b

function old new delta
start_stop_daemon_main 1186 1206 +20
bb_daemonize_or_rexec 196 212 +16
bb_banner 47 46 -1
packed_usage 34656 34645 -11
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/2 up/down: 36/-12) Total: 24 bytes

Signed-off-by: Denys Vlasenko <email address hidden>

17721. By Vda-linux

start-stop-daemon: typo fix

Signed-off-by: Denys Vlasenko <email address hidden>

17720. By Louai Al-Khanji <email address hidden>

start-stop-daemon: implement option -O|--output

If specified redirect command stdout and stderr to given pathname.

function old new delta
start_stop_daemon_main 1130 1186 +56
start_stop_daemon_longopts 164 173 +9
packed_usage 34653 34656 +3
.rodata 105384 105386 +2
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/0 up/down: 70/0) Total: 70 bytes

Signed-off-by: Louai Al-Khanji <email address hidden>
Signed-off-by: Denys Vlasenko <email address hidden>

17719. By Petr Vorel <email address hidden>

sleep: Update doc

4c20d9f2b removed FEATURE_FLOAT_SLEEP option, thus since then there are
only two variants.

Fixes: 4c20d9f2b ("extend fractional duration support to "top -d N.N" and "timeout"")
Signed-off-by: Petr Vorel <email address hidden>
Signed-off-by: Denys Vlasenko <email address hidden>

17718. By Vda-linux

start-stop-daemon: update comment, no code changes

Signed-off-by: Denys Vlasenko <email address hidden>

17717. By ejaaskel <email address hidden>

start-stop-daemon: add -d DIR chdir option

Add option to change the running directory before starting the process.
This can be done using -d or --chdir options. Add also test cases to
start-stop-daemon to test out the directory change option.

function old new delta
packed_usage 34602 34648 +46
start_stop_daemon_main 1107 1130 +23
start_stop_daemon_longopts 156 164 +8
.rodata 105382 105384 +2
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/0 up/down: 79/0) Total: 79 bytes

Signed-off-by: ejaaskel <email address hidden>
Signed-off-by: Denys Vlasenko <email address hidden>

17716. By Vda-linux

start-stop-daemon: fix --help: -K or -S is required

function old new delta
.rodata 105381 105382 +1
packed_usage 34638 34602 -36
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 1/-36) Total: -35 bytes

Signed-off-by: Denys Vlasenko <email address hidden>

17715. By Russ Dill

udhcp: Avoid leaking uninitialized/stale data

I noticed a commit in connman:

"gdhcp: Avoid leaking stack data via unitiialized variable" [1]

Since gdhcp is just BusyBox udhcp with the serial numbers filed off, I
checked if BusyBox udhcp has a related issue.

The issue is that the get_option logic assumes any data within the
memory area of the buffer is "valid". This reduces the complexity of the
function at the cost of reading past the end of the actually received
data in the case of specially crafted packets. This is not a problem
for the udhcp_recv_kernel_packet data path as the entire memory
area is zeroed. However, d4/d6_recv_raw_packet does not zero the
memory.

Note that a related commit [2] is not required as we are zeroing
any data that can be read by the get_option function.

[1] https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=a74524b3e3fad81b0fd1084ffdf9f2ea469cd9b1
[2] https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=58d397ba74873384aee449690a9070bacd5676fa

function old new delta
d4_recv_raw_packet 484 497 +13
d6_recv_raw_packet 216 228 +12
.rodata 105390 105381 -9
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/1 up/down: 25/-9) Total: 16 bytes

Signed-off-by: Russ Dill <email address hidden>
Cc: Colin Wee <email address hidden>
Cc: Denys Vlasenko <email address hidden>
Signed-off-by: Denys Vlasenko <email address hidden>

17714. By Vda-linux

syslogd: fix breakage caused by "daemonize _after_ init" change

function old new delta
syslogd_init 1007 1140 +133
create_socket 143 - -143
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 1/0 up/down: 133/-143) Total: -10 bytes

Signed-off-by: Denys Vlasenko <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.