lp://qastaging/libice

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

173. By Alan Coopersmith on 2019-07-14

libICE 1.0.10

Signed-off-by: Alan Coopersmith <email address hidden>

172. By Olivier Fourdan <email address hidden> on 2019-04-11

cleanup: Separate variable assignment and test

Assigning and testing a value in a single statement hinders code clarity
and may confuses static code analyzers.

Separate the assignment and the test for clarity.

Signed-off-by: Olivier Fourdan <email address hidden>

171. By Olivier Fourdan <email address hidden> on 2019-04-10

_IceRead: Avoid possible use-after-free

`_IceRead()` gets called from multiple places which do not expect the
connection to be freed.

Do not free the connection data in `_IceRead()` to avoid potential
use-after-free issue in the various callers.

The connection data will be freed eventually in `ProcessWantToClose()`,
so not freeing it in `_IceRead()` should not introduce an memory leak.

Signed-off-by: Olivier Fourdan <email address hidden>

170. By Olivier Fourdan <email address hidden> on 2019-04-10

IceListenForWellKnownConnections: Fix memleak

The function `_IceTransMakeAllCOTSServerListeners` allocates memory for
`transConns` which is leaked in case of error.

Signed-off-by: Olivier Fourdan <email address hidden>

169. By Alan Coopersmith on 2019-03-24

IceWritePad: always use zero values for pad bytes

Previously it would just bump the pointer in the buffer leaving
whatever values were previously there in place.

Signed-off-by: Alan Coopersmith <email address hidden>

168. By Alan Coopersmith on 2019-03-24

IceOpenConnection: check for malloc failure on connect_to_you too

Fixes: https://gitlab.freedesktop.org/xorg/lib/libice/issues/4

Reported-by: mahendra <email address hidden>
Signed-off-by: Alan Coopersmith <email address hidden>

167. By Allison Karlitskaya on 2019-03-24

authutil: support $XDG_RUNTIME_DIR/ICEauthority

If we find that $XDG_RUNTIME_DIR is set (and $ICEAUTHORITY is not), then
the ICEauthority file is stored in the XDG_RUNTIME_DIR instead of the
home directory, and without a leading dot.

https://bugs.freedesktop.org/show_bug.cgi?id=49173
Signed-off-by: Alan Coopersmith <email address hidden>

166. By Allison Karlitskaya on 2019-03-24

authutil: fix an out-of-bounds access

There is a theoretical edge case where the $HOME environment variable
could be set to the empty string. IceAuthFileName() unconditionally
checks index 1 of this string, which is out of bounds.

Fix that up by rejecting empty strings in the same way as we reject
NULL.

https://bugs.freedesktop.org/show_bug.cgi?id=49173
Signed-off-by: Alan Coopersmith <email address hidden>

165. By Tobias Stoeckmann <email address hidden> on 2019-03-10

Always terminate strncpy results.

The function strncpy does not guarantee to append a terminating
NUL character to the destination.

This patch merges libSM's way of handling this issue into libICE.

Signed-off-by: Tobias Stoeckmann <email address hidden>
Signed-off-by: Alan Coopersmith <email address hidden>

164. By Wharms-bfs on 2019-03-03

iceauth.c: FIX warning: unused variable 'ret' in 'arc4random_buf'

commit ff5e59f32255913bb1cdf51441b98c9107ae165b left ret outside the #if
causing a gcc warning:

 In function 'arc4random_buf':
 iceauth.c:89:13: warning: unused variable 'ret' [-Wunused-variable]

fixed by moving #if 1 up

Signed-off-by: Walter Harms <email address hidden>
Reviewed-by: Alan Coopersmith <email address hidden>
Signed-off-by: Alan Coopersmith <email address hidden>