lp://qastaging/make

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

1 recipe using this branch. (?)

Related snap packages

Related bugs

Related blueprints

3173. By Paul Smith on 2025-08-27

[SV 67046] Don't modify the hash table when inside hash_map*()

It's illegal for the user-supplied function to modify the hash table
while executing hash_map*() methods. snap_file() may add elements
due to EXTRA_PREREQS, so we can't call it via hash_map_args().

Diagnosis and test by Shim Manning <email address hidden>
Possible fix by Dmitry Goncharov <email address hidden>

* src/hash.h (hash_table): Remember when we're in hash_map*().
* src/hash.c (hash_init): Initialize the in-map value to false.
(hash_map): Set the in-map value to true when walking the map.
(hash_map_arg): Ditto.
(hash_insert_at): Assert we're not in hash_map*()
(hash_free_items): Ditto.
(hash_delete_items): Ditto.
(hash_free): Ditto.
* src/file.c (snap_deps): Use hash_dump() to create a copy of the
hash and walk that to call snap_file(), so we can add more files.
(snap_file): Since we're calling it directly, don't use void* args.

3172. By Paul Smith on 2025-08-27

* doc/make.texi: [SV 66490] Clarify patsubst matches an entire word

3171. By Paul Smith on 2025-08-27

* doc/make.texi: [SV 66974] Explain unmatched include glob patterns

3170. By Paul Smith on 2025-08-27

* bootstrap.bat: [SV 67162] Use curl -L to follow redirects

3169. By Paul Smith on 2025-08-27

* tests/scripts/features/patternrules: Check unreadable file support

3168. By Paul Smith on 2025-08-27

* tests/*: Quote backticked command paths

When using Perl's backticks make sure that the path to the command
invoked is quoted. On Windows, in particular, paths to commands such
as diff, etc. may contain whitespace.

3167. By Paul Smith on 2025-08-26

[SV 64185] Clarify handling of directive lines starting with TAB

It's clear that this change causes too many problems to be made
without warning. Revert the change disallowing conditional lines to
start with TAB.

Instead, generate warnings whenever a directive line begins with a
TAB character. Make this change for all directives, not just
conditional directives: define, undefine, export, unexport, vpath,
load, include, etc.

* NEWS: Update the backward-compatibility warning.
* src/read.c (eval): Track whether the line starts with a TAB.
If so then whenever we recognize a directive, emit a warning.
Revert the previous change for this bug.
(parse_var_assignment): Accept a file location if the line begins
with TAB; show a warning if we discover a directive.
(conditional_line): Warn about lines starting with TAB.
* tests/scripts/...: Add tests to verify warnings for initial TAB.

3166. By Paul Smith on 2025-08-24

* tests/scripts/*: Switch TAB chars to #TAB# markup

Avoid Emacs local variable settings to disable whitespace cleanup,
by creating markup tokens for TAB characters (#TAB#) and space
characters (#SPACE#) (for end-of-line spaces). Modify all the
tests that use TABs to use the new markup. This requires changing
some old-fashioned tests to use the modern run_make_test(). Also
remove some of the comments regarding test numbers now that the
framework keeps track.

3165. By Paul Smith on 2025-08-24

* all: Update copyright year to 2025

3164. By Ingo Rohloff <email address hidden> on 2025-08-23

* doc/make.texi: [SV 67428] Clarify $(findstring ...) docs