lp://qastaging/reviewboard

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Related snap packages

Related bugs

Related blueprints

5116. By Christian Hammond <email address hidden> on 2025-08-06

Merge branch 'release-7.1.x'

5115. By Christian Hammond <email address hidden> on 2025-07-31

Merge branch 'release-7.1.x'

5114. By David Trowbridge <email address hidden> on 2025-07-18

Merge branch 'release-7.1.x'

5113. By David Trowbridge <email address hidden> on 2025-07-10

Update the types for diff chunks and lines.

This change defines a `TypedDict` for diff chunks, and a `tuple` for
diff lines, with definitions and documentation for each element.

Before, these were just an opaque dictionary, and a heterogenous list.
The diff lines were particularly annoying because they were variable
length (if there was no metadata, that element was just left off the
end), and types were annoying (for "real" line numbers, we'd have an
int if the line was present on that side of the diff, but an empty
string if not). This change technically breaks compatibility in those
two cases.

We now always include the metadata field, set to `None` if there's no
metadata for the line. This increases the cached size of a very large
diff with thousands of lines by less that 0.1% (much better than many
years ago with older pickle protocols--the tuple is probably also
helping here).

In the case of real line numbers which are not present on one side of
the diff (for example, the line number of an added line for the
left-hand side of the diff), we set the data for that to `None`. In
order to maintain compatibility with current versions of Review Bot, we
change `None` line numbers back to an empty string for the filediff
resource's `diff_data` mode.

This change only touches code related to chunks and lines. Other diff
viewer cleanup is coming in later changes.

Testing Done:
- Tested a ton of different diffs, both in the diff viewer as well as
  the text and markdown Review UIs. Verified that all types of edits
  (added/edited/deleted/moved) lines all worked as expected.
- Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/14399/

5112. By David Trowbridge <email address hidden> on 2025-07-10

Update integrations documentation for consistency.

This change updates the documentation for our various integrations to
ensure consistency across pages. We had slightly different variations of
headers and connfiguration steps, and a few places where things were
just inconsistent with things like colons.

Testing Done:
Built docs and checked the output.

Reviewed at https://reviews.reviewboard.org/r/14465/

5111. By David Trowbridge <email address hidden> on 2025-07-10

Merge branch 'release-7.1.x'

5110. By David Trowbridge <email address hidden> on 2025-06-10

Merge branch 'release-7.1.x'

5109. By David Trowbridge on 2025-06-10

Convert RB.UploadAttachmentView to TypeScript/spina/Ink.

This change ports the UploadAttachmentView to TypeScript, and changes it
so it now inherits from the new `Ink.DialogView`.

Testing Done:
- Ran js-tests.
- Uploaded new file attachments.
- Uploaded new versions of existing file attachments.

Reviewed at https://reviews.reviewboard.org/r/14161/

5108. By David Trowbridge on 2025-06-10

Remove long-deprecated callbacks style resource invocations.

In Review Board 5, we added promises for our asynchronous operations in
our resource classes. We did this with fallbacks to handle old-style
calls that passed in callback methods. This change converts those
fallbacks to be errors instead.

Testing Done:
Ran js-tests.

Reviewed at https://reviews.reviewboard.org/r/14158/

5107. By David Trowbridge on 2025-06-10

Convert apiUtils to TypeScript.

This change converts our API methods to TypeScript. Our apiUtils file
has a few methods, primary among them being `apiCall`. This change adds
typing for everything, and cleans up some old cruft. It does not yet
make any changes to the internals of how API requests work.

In order to facilitate using jasmine for unit tests. these methods are
all exported under a new top-level object called `API`.

Testing Done:
- Ran js-tests.
- Smoke tested the UI and verified that things still worked correctly.

Reviewed at https://reviews.reviewboard.org/r/14157/