lp://qastaging/reviewboard
- Get this branch:
- bzr branch lp://qastaging/reviewboard
Branch merges
Branch information
Import details
This branch is an import of the HEAD branch of the Git repository at https://github.com/reviewboard/reviewboard.git.
Last successful import was .
Recent revisions
- 5088. By Michelle Aubin <email address hidden>
-
Fix a bad Ink import.
One file was importing Ink from the wrong path, causing build errors.
This change fixes that.Testing Done:
Built Review Board and ran the dev server without error.Reviewed at https:/
/reviews. reviewboard. org/r/14263/ - 5087. By Beth Rennie <email address hidden>
-
Update my name in the tree
Reviewed at https:/
/reviews. reviewboard. org/r/14236/ - 5084. By David Trowbridge
-
Remove old DraftReviewBann
erView. The new unified banner is fully stable, and we're never going back to
the old banners. This change removes the DraftReviewBannerView. Testing Done:
Ran js-tests.Reviewed at https:/
/reviews. reviewboard. org/r/14097/ - 5083. By David Trowbridge
-
Convert a couple of legacy test files to TypeScript.
The MenuView and MenuButtonView were converted to TypeScript a while
ago, but we didn't convert the matching test files. This change does
that.These views are obsolete anyway because we are moving to Ink's versions.
Testing Done:
Ran js-tests.Reviewed at https:/
/reviews. reviewboard. org/r/14096/ - 5082. By David Trowbridge
-
Convert RB.OAuthClientS
ecretView to TypeScript/spina This change converts the OAauth client secret widget JS to TypeScript
and spina. I decided to merge this into the "widgets" bundle, since it
seemed excessive to have a separate bundle just for this one file.Testing Done:
- Ran js-tests.
- Verified that the OAuth secret input still worked as expected.Reviewed at https:/
/reviews. reviewboard. org/r/14095/ - 5081. By David Trowbridge
-
Switch to Ink buttons for the OAuth application form.
This change switches to using Ink buttons for the OAuth application form
template.Testing Done:
Loaded the OAuth application form and saw the new buttons.Reviewed at https:/
/reviews. reviewboard. org/r/14094/ - 5080. By David Trowbridge
-
Convert RB.OAuthTokensView to TypeScript/spina.
This change converts the RB.OAuthTokensView config forms views to
TypeScript.The only functional change is that while doing this I discovered that we
were always showing the "You do not have any OAuth2 tokens" text, even
when there were tokens in the list.Testing Done:
- Ran js-tests.
- Created Oauth tokens (via the admin site) and saw them in the list,
and removed them via the UI.Reviewed at https:/
/reviews. reviewboard. org/r/14093/
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)