desktopcouch

Merge lp://qastaging/~vds/desktopcouch/add_test_coverage into lp://qastaging/desktopcouch

add_test_coverage
Merge into trunk

Proposed by Vincenzo Di Somma on 2010-11-11

Status:

Merged

Approved by:

Eric Casteleijn on 2010-11-12

Approved revision:

204

Merged at revision:

203

Proposed branch:

lp://qastaging/~vds/desktopcouch/add_test_coverage

Merge into:

lp://qastaging/desktopcouch

Diff against target:

221 lines (+73/-25)

4 files modified

desktopcouch/records/tests/test_field_registry.py (+21/-4)
desktopcouch/records/tests/test_record.py (+22/-3)
runtests.py (+27/-9)
utilities/lint.sh (+3/-9)

To merge this branch:

bzr merge lp://qastaging/~vds/desktopcouch/add_test_coverage

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Eric Casteleijn (community)		Approve on 2010-11-12
Chad Miller (community)	2010-11-11	Approve on 2010-11-12
Review via email: mp+40661@code.qastaging.launchpad.net

Commit message

Add script runtest.sh that now runs both lint and coverage check.

Description of the change

Add script runtest.sh that now runs both lint and coverage check.

Revision history for this message

Chad Miller (cmiller) wrote on 2010-11-11:

I don't especially like the new "runtests.sh". I think all its contents should be in "runtests.py" instead.

subprocess.call() for all the lines except "pyfiles=".

find is

source_files = list()
for dir, filenames in os.walk:
   for filename in filenames:
       if filename.endswith(".py") and "test_" not in filename:
            source_files.append(os.join(dir, filename))

or something like that.

then subprocess.call(['python-coverage', '-r'] + source_files)

review: Needs Fixing

Revision history for this message

Vincenzo Di Somma (vds) wrote on 2010-11-12:

Moved everything to the runtests.py.

lp://qastaging/~vds/desktopcouch/add_test_coverage updated on 2010-11-12