Merge lp://qastaging/~vds/desktopcouch/again_python_couchdb into lp://qastaging/desktopcouch

Proposed by Vincenzo Di Somma
Status: Merged
Approved by: dobey
Approved revision: 227
Merged at revision: 234
Proposed branch: lp://qastaging/~vds/desktopcouch/again_python_couchdb
Merge into: lp://qastaging/desktopcouch
Diff against target: 1043 lines (+376/-222)
20 files modified
desktopcouch/application/local_files.py (+1/-1)
desktopcouch/application/migration/__init__.py (+3/-1)
desktopcouch/application/migration/tests/test_migration.py (+18/-1)
desktopcouch/application/pair/couchdb_pairing/couchdb_io.py (+7/-15)
desktopcouch/application/pair/couchdb_pairing/ubuntuone_pairing.py (+2/-8)
desktopcouch/application/platform/__init__.py (+1/-0)
desktopcouch/application/platform/linux/base_dirs.py (+1/-0)
desktopcouch/application/server.py (+12/-19)
desktopcouch/application/service.py (+2/-1)
desktopcouch/bookmarks/__init__.py (+0/-1)
desktopcouch/bookmarks/record.py (+0/-9)
desktopcouch/notes/__init__.py (+0/-1)
desktopcouch/notes/record.py (+0/-9)
desktopcouch/records/database.py (+38/-129)
desktopcouch/records/http.py (+266/-0)
desktopcouch/records/tests/test_server.py (+19/-7)
desktopcouch/recordtypes/contacts/testing/create.py (+6/-2)
desktopcouch/recordtypes/contacts/view.py (+0/-8)
desktopcouch/tasks/__init__.py (+0/-1)
desktopcouch/tasks/record.py (+0/-9)
To merge this branch: bzr merge lp://qastaging/~vds/desktopcouch/again_python_couchdb
Reviewer Review Type Date Requested Status
Chad Miller (community) Approve
Manuel de la Peña (community) Approve
Eric Casteleijn (community) Approve
Review via email: mp+41170@code.qastaging.launchpad.net

Commit message

Port to use python-couchdb 0.8. This makes future desktopcouch incompatible with previous versions of python-couchdb.

Description of the change

Port to python-couchdb 0.8, to test it download it from here:
http://goo.gl/UDmnx
Unpack and put the couchdb folder in the root of the branch.

To post a comment you must log in.
Revision history for this message
Eric Casteleijn (thisfred) wrote :

looks good to me, tests pass.

review: Approve
Revision history for this message
Eric Casteleijn (thisfred) wrote :

We should probably package python-couchdb before we land this though. :(

Revision history for this message
Manuel de la Peña (mandel) wrote :

+1, thx!

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Attempt to merge into lp:desktopcouch failed due to conflicts:

text conflict in desktopcouch/records/server_base.py

Revision history for this message
Chad Miller (cmiller) wrote :

98 +"""This modules olds some code

?

244 + if isinstance(body, str):

Should this be basestr instead of str? I don't know if Unicode should ever be sent as body, but if it is, should it be treated as a file in "else"?

Revision history for this message
Eric Casteleijn (thisfred) wrote :

The deprecated files are still gone, and I get 2 conflicts when merging this branch into trunk.

Revision history for this message
Chad Miller (cmiller) wrote :

Natty hackers ppa ready. Let's land this!

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Attempt to merge into lp:desktopcouch failed due to conflicts:

text conflict in desktopcouch/application/migration/__init__.py
text conflict in desktopcouch/application/server.py
text conflict in desktopcouch/records/database.py
text conflict in desktopcouch/records/tests/test_server.py

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Attempt to merge into lp:desktopcouch failed due to conflicts:

missing parent in utilities
unversioned parent in utilities
contents conflict in utilities/lint.sh

227. By Vincenzo Di Somma

merged trunk, resolved conflicts

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches