Merge lp://qastaging/~vds/desktopcouch/fix_delete_record_reconnection into lp://qastaging/desktopcouch

Proposed by Vincenzo Di Somma
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 179
Merged at revision: 178
Proposed branch: lp://qastaging/~vds/desktopcouch/fix_delete_record_reconnection
Merge into: lp://qastaging/desktopcouch
Diff against target: 90 lines (+35/-14)
2 files modified
desktopcouch/records/server_base.py (+13/-10)
desktopcouch/records/tests/test_server.py (+22/-4)
To merge this branch: bzr merge lp://qastaging/~vds/desktopcouch/fix_delete_record_reconnection
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Vincenzo Di Somma (community) Approve
Eric Casteleijn (community) Approve
Review via email: mp+37006@code.qastaging.launchpad.net

Commit message

Fixes a problem with delete files and reconnection.

Description of the change

Fixes a problem with delete files and reconnection.

To post a comment you must log in.
Revision history for this message
Eric Casteleijn (thisfred) wrote :

Looks good, tests pass

review: Approve
Revision history for this message
Vincenzo Di Somma (vds) wrote :

Three unrelated errors in tests. Looks very good!

===============================================================================
[ERROR]: canonical.tests.test_share_sync.TestShareClientMove.test_syncs_get_changed_file_hash

Traceback (most recent call last):
Failure: ubuntuone.u1sync.main.TreesDiffer:
===============================================================================
[ERROR]: canonical.tests.test_sync.TestClientMove.test_syncs_get_changed_file_hash

Traceback (most recent call last):
Failure: ubuntuone.u1sync.main.TreesDiffer:
===============================================================================
[ERROR]: canonical.tests.test_udf_sync.TestUDFClientMove.test_syncs_get_changed_file_hash

Traceback (most recent call last):
Failure: ubuntuone.u1sync.main.TreesDiffer:

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

+1 Ran all the tests, no issues. Code looks good to me.

review: Approve
Revision history for this message
Vincenzo Di Somma (vds) wrote :

Sorry, wrong browser window! :(

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches