Merge lp://qastaging/~vds/desktopcouch/refactor_class_factory into lp://qastaging/desktopcouch
Proposed by
Vincenzo Di Somma
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Vincenzo Di Somma | ||||
| Approved revision: | 191 | ||||
| Merged at revision: | 186 | ||||
| Proposed branch: | lp://qastaging/~vds/desktopcouch/refactor_class_factory | ||||
| Merge into: | lp://qastaging/desktopcouch | ||||
| Diff against target: |
431 lines (+141/-170) 7 files modified
desktopcouch/contacts/record.py (+32/-42) desktopcouch/contacts/tests/test_record.py (+23/-18) desktopcouch/notes/record.py (+18/-47) desktopcouch/notes/tests/test_record.py (+27/-22) desktopcouch/records/record.py (+22/-0) desktopcouch/tasks/record.py (+11/-30) desktopcouch/tasks/tests/test_record.py (+8/-11) |
||||
| To merge this branch: | bzr merge lp://qastaging/~vds/desktopcouch/refactor_class_factory | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Manuel de la Peña (community) | Approve | ||
| Eric Casteleijn (community) | Approve | ||
|
Review via email:
|
|||
Commit message
The class factories are not making the code look nice, are just making more confusion, plus all the tests weren't actually testing nothing.
Description of the change
The class factories are not making the code look nice, are just making more confusion, plus all the tests weren't actually testing nothing.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Big improvement, tests pass, yay!