Merge lp://qastaging/~vds/desktopcouch/remove_delete_flag into lp://qastaging/desktopcouch
Proposed by
Vincenzo Di Somma
| Status: | Merged |
|---|---|
| Approved by: | John Lenton |
| Approved revision: | 198 |
| Merged at revision: | 197 |
| Proposed branch: | lp://qastaging/~vds/desktopcouch/remove_delete_flag |
| Merge into: | lp://qastaging/desktopcouch |
| Diff against target: |
316 lines (+81/-49) 3 files modified
desktopcouch/records/server.py (+41/-4) desktopcouch/records/server_base.py (+12/-13) desktopcouch/records/tests/test_server.py (+28/-32) |
| To merge this branch: | bzr merge lp://qastaging/~vds/desktopcouch/remove_delete_flag |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John Lenton (community) | Approve | ||
| Eric Casteleijn (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Instead of deleting records we are marking as deleted in private application annotation, but we don't want to maintain "deleted" records in the database for ever, it's bad for couchdb both for views performance and coding the views.
What we want to do is move the records to a "trash" database that can be replicated and can offer undo functionalities.
Description of the change
Instead of deleting records we are marking as deleted in private application annotation, but we don't want to maintain "deleted" records in the database for ever, it's bad for couchdb both for views performance and coding the views.
What we want to do is move the records to a "trash" database that can be replicated and can offer undo functionalities.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I LOVE it! Also, the tests pass... +1000