desktopcouch

Merge lp://qastaging/~vds/desktopcouch/simple_migration_infrastructure into lp://qastaging/desktopcouch

  1. simple_migration_infrastructure
  2. Merge into trunk
Proposed by Vincenzo Di Somma
Status: Merged
Approved by: Chad Miller
Approved revision: 212
Merged at revision: 210
Proposed branch: lp://qastaging/~vds/desktopcouch/simple_migration_infrastructure
Merge into: lp://qastaging/desktopcouch
Diff against target: 308 lines (+263/-1)
5 files modified
bin/desktopcouch-get-port (+5/-0)
desktopcouch/migration/__init__.py (+80/-0)
desktopcouch/migration/tests/__init__.py (+1/-0)
desktopcouch/migration/tests/test_migration.py (+176/-0)
runtests.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~vds/desktopcouch/simple_migration_infrastructure
Reviewer Review Type Date Requested Status
Chad Miller (community) Approve
Manuel de la Peña (community) Approve
Eric Casteleijn (community) Approve
Review via email: mp+40988@code.qastaging.launchpad.net

Commit message

Add basic migration infrastructure, to facilitate at least a planned switch from deleted-flagged records to a separate Trash database. (LP: #670700, #675590)

Description of the change

Basic migration infrastructure.

To post a comment you must log in.
lp://qastaging/~vds/desktopcouch/simple_migration_infrastructure updated
211. By Vincenzo Di Somma

pylint happy (again)

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Looks good, tests pass.

review: Approve
lp://qastaging/~vds/desktopcouch/simple_migration_infrastructure updated
212. By Vincenzo Di Somma

thisfred happy

Revision history for this message
Manuel de la Peña (mandel) wrote :

This is a +1 from me. Nevertheless we should aim to get all our unittests to use mocker to mock the db access. I have added a bug report and assign it to vds so that we do not forget, bug number is lp:676476

review: Approve
Revision history for this message
Chad Miller (cmiller) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches