charm-haproxy

Merge lp://qastaging/~vern/charm-haproxy/fix-install-hook into lp://qastaging/charm-haproxy

  1. fix-install-hook
  2. Merge into trunk
Proposed by Vern Hart
Status: Merged
Approved by: Tom Haddon
Approved revision: 148
Merged at revision: 148
Proposed branch: lp://qastaging/~vern/charm-haproxy/fix-install-hook
Merge into: lp://qastaging/charm-haproxy
Diff against target: 36 lines (+7/-17)
1 file modified
hooks/install (+7/-17)
To merge this branch: bzr merge lp://qastaging/~vern/charm-haproxy/fix-install-hook
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Paul Collins lgtm Approve
Review via email: mp+410140@code.qastaging.launchpad.net

Commit message

Simplify install hook (works on bionic and focal).

Fixes: https://bugs.launchpad.net/charm-haproxy/+bug/1946798

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Paul Collins (pjdc) :
review: Approve (lgtm)
Revision history for this message
Vern Hart (vern) wrote :

Note that I tested this on bionic and focal by deploying with --series:

  juju deploy ../../charms/haproxy haproxyb --bind oam-space --series bionic --to lxd:0
  juju deploy ../../charms/haproxy haproxyf --bind oam-space --series focal --to lxd:0

And verifying that the charms installed correctly.

Revision history for this message
Tom Haddon (mthaddon) wrote :

This is a nice simplification. Thanks.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 148

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: