poll-daemon

Merge lp://qastaging/~verterok/account-polld/handle-account-created into lp://qastaging/~ubuntu-push-hackers/account-polld/trunk

handle-account-created
Merge into trunk

Proposed by Guillermo Gonzalez on 2014-08-13

Status:	Rejected
Rejected by:	Guillermo Gonzalez on 2014-08-22
Proposed branch:	lp://qastaging/~verterok/account-polld/handle-account-created
Merge into:	lp://qastaging/~ubuntu-push-hackers/account-polld/trunk
Diff against target:	423 lines (+174/-69) 6 files modified accounts/account-watcher.c (+30/-1) accounts/account-watcher.h (+6/-0) accounts/accounts.c (+2/-1) accounts/accounts.go (+36/-14) cmd/account-polld/main.go (+74/-39) po/account-polld.pot (+26/-14)
To merge this branch:	bzr merge lp://qastaging/~verterok/account-polld/handle-account-created
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Sergio Schvezov		2014-08-13	Approve on 2014-08-19
PS Jenkins bot	continuous-integration		Approve on 2014-08-15
Review via email: mp+230686@code.qastaging.launchpad.net

Commit message

Send a notification when an account is created, which actions is to open the accounts settings page.

Description of the change

Send a notification when an account is created, which actions is to open the accounts settings page (this will be changed when we can open a specific account page)

To test this on the device you will need an updated push-helper, grab this: http://paste.ubuntu.com/8038589/ and save it as: /usr/lib/ubuntu-push-client/legacy-helpers/ubuntu-system-settings

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13:

PASSED: Continuous integration, rev:56
http://jenkins.qa.ubuntu.com/job/account-polld-ci/63/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-amd64-ci/63
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/63
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/63/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-i386-ci/63

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/63/rebuild

review: Approve (continuous-integration)

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-08-13:

couple of inline comments added; I will test in a bit as well.

review: Needs Fixing

Revision history for this message

Guillermo Gonzalez (verterok) on 2014-08-13:

lp://qastaging/~verterok/account-polld/handle-account-created updated on 2014-08-13

57. By Guillermo Gonzalez on 2014-08-13: add missing TRANSLATORS comments
58. By Guillermo Gonzalez on 2014-08-13: updated translations

Revision history for this message

Guillermo Gonzalez (verterok) on 2014-08-13:

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13:

PASSED: Continuous integration, rev:58
http://jenkins.qa.ubuntu.com/job/account-polld-ci/64/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-amd64-ci/64
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/64
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/64/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-i386-ci/64

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/64/rebuild

review: Approve (continuous-integration)

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-08-14:

if I install this, I don't get updates anymore; only an account creation signal

lp://qastaging/~verterok/account-polld/handle-account-created updated on 2014-08-14

59. By Guillermo Gonzalez on 2014-08-14: move mainloop setup into main
60. By Guillermo Gonzalez on 2014-08-14: merge with trunk

Revision history for this message

Guillermo Gonzalez (verterok) wrote on 2014-08-14:

inline comments regarding the mainloop change.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14:

PASSED: Continuous integration, rev:60
http://jenkins.qa.ubuntu.com/job/account-polld-ci/66/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-amd64-ci/66
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/66
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/66/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-i386-ci/66

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/66/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14:

PASSED: Continuous integration, rev:60
http://jenkins.qa.ubuntu.com/job/account-polld-ci/67/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/67/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-i386-ci/67

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/67/rebuild

review: Approve (continuous-integration)

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-08-15:

[00:28:32] <sergiusens> I do get the message now, what I don't see working is the actual notifications
[00:28:45] <sergiusens> enabling or disabling the toggle does not trigger the poll loop

and two minor inline comments

review: Needs Fixing

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-08-15:

once more comment

review: Needs Fixing

lp://qastaging/~verterok/account-polld/handle-account-created updated on 2014-08-15

61. By Guillermo Gonzalez on 2014-08-15: start the mainlopp in init()
62. By Guillermo Gonzalez on 2014-08-15: update notification body

Revision history for this message

Guillermo Gonzalez (verterok) wrote on 2014-08-15:

Thanks for the review.

Fixed & pushed the 3 issues, I'll test it once jenkins finishes with the build.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-15:

PASSED: Continuous integration, rev:62
http://jenkins.qa.ubuntu.com/job/account-polld-ci/68/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-amd64-ci/68
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/68
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/68/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-i386-ci/68

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/68/rebuild

review: Approve (continuous-integration)

lp://qastaging/~verterok/account-polld/handle-account-created updated on 2014-08-15

63. By Guillermo Gonzalez on 2014-08-15: remove break from the accountCh case

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-15:

PASSED: Continuous integration, rev:63
http://jenkins.qa.ubuntu.com/job/account-polld-ci/69/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-amd64-ci/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/69
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/69/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-i386-ci/69

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/69/rebuild

review: Approve (continuous-integration)

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-08-19:

tested, works

review: Approve

Unmerged revisions

63. By Guillermo Gonzalez on 2014-08-15: remove break from the accountCh case
62. By Guillermo Gonzalez on 2014-08-15: update notification body
61. By Guillermo Gonzalez on 2014-08-15: start the mainlopp in init()
60. By Guillermo Gonzalez on 2014-08-14: merge with trunk
59. By Guillermo Gonzalez on 2014-08-14: move mainloop setup into main
58. By Guillermo Gonzalez on 2014-08-13: updated translations
57. By Guillermo Gonzalez on 2014-08-13: add missing TRANSLATORS comments
56. By Guillermo Gonzalez on 2014-08-13: fix the dbus path
55. By Guillermo Gonzalez on 2014-08-13: - improve the notification message
- update translations
54. By Guillermo Gonzalez on 2014-08-12: use the correct url for the accounts settings page