Ubuntu One Client

Merge lp://qastaging/~verterok/ubuntuone-client/fix-452682-stable into lp://qastaging/ubuntuone-client/stable-1-2

  1. fix-452682-stable
  2. Merge into stable-1-2
Proposed by Guillermo Gonzalez
Status: Merged
Approved by: Guillermo Gonzalez
Approved revision: 509
Merged at revision: 508
Proposed branch: lp://qastaging/~verterok/ubuntuone-client/fix-452682-stable
Merge into: lp://qastaging/ubuntuone-client/stable-1-2
Diff against target: 45 lines (+17/-0)
2 files modified
tests/syncdaemon/test_vm.py (+13/-0)
ubuntuone/syncdaemon/volume_manager.py (+4/-0)
To merge this branch: bzr merge lp://qastaging/~verterok/ubuntuone-client/fix-452682-stable
Reviewer Review Type Date Requested Status
Roman Yepishev (community) Approve
Joshua Hoover (community) ran branch and verified fix Approve
Rick McBride Pending
Review via email: mp+25789@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2010-05-19.

Commit message

Fix 'Shared With Me' symlink if the target was changed and the link is broken.

Description of the change

Fix 'Shared With Me' symlink if the target was changed and the link is broken.

To post a comment you must log in.
Revision history for this message
Roman Yepishev (rye) wrote : Posted in a previous version of this proposal

Tested the behavior using the stable branch directly.

review: Approve
Revision history for this message
Rick McBride (rmcbride) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Rick McBride (rmcbride) wrote : Posted in a previous version of this proposal

oops. Missed that Mr. Hoover is a requested review.

Revision history for this message
Joshua Hoover (joshuahoover) wrote : Posted in a previous version of this proposal

Passed test case for #452682

review: Approve (ran branch and verified fix)
Revision history for this message
Joshua Hoover (joshuahoover) wrote :

Passed test case for #452682. Tested updated branch with stable protocol.

review: Approve (ran branch and verified fix)
Revision history for this message
Roman Yepishev (rye) wrote :

<rye> verterok, is it supposed to fix ln -s /tmp "$HOME/Ubuntu One/Shared With Me" ?
<verterok> rye: only broken symlinks not poiting to the real shares directory
<verterok> rye: e.g: ln -s foobar "$HOME/Ubuntu One/Shared With Me"

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches