Merge lp://qastaging/~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async into lp://qastaging/ubuntu-docviewer-app
Proposed by
Stefano Verzegnassi
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Alan Pope 🍺🐧🐱 🦄 | ||||
| Approved revision: | 342 | ||||
| Merged at revision: | 353 | ||||
| Proposed branch: | lp://qastaging/~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async | ||||
| Merge into: | lp://qastaging/ubuntu-docviewer-app | ||||
| Diff against target: |
10 lines (+0/-1) 1 file modified
src/app/qml/ubuntu-docviewer-app.qml (+0/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
| Jenkins Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Do not initialize content-hub asynchronously, otherwise a transfer can not be finalized if the app is not already launched.
This bug likely exists since months, but after the recent changes in content-hub it seems easier to trigger.
Description of the change
Do not initialize content-hub asynchronously, otherwise a transfer can not be finalized if the app is not already launched.
This bug likely exists since months, but after the recent changes in content-hub it seems easier to trigger.
To post a comment you must log in.
Revision history for this message
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:342
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/