Merge lp://qastaging/~vexo/bzr-webdav/bzr-webdav into lp://qastaging/bzr-webdav
Proposed by
Reagan Sanders
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 76 | ||||||||
Proposed branch: | lp://qastaging/~vexo/bzr-webdav/bzr-webdav | ||||||||
Merge into: | lp://qastaging/bzr-webdav | ||||||||
Diff against target: |
117 lines (+35/-8) 2 files modified
tests/dav_server.py (+28/-2) webdav.py (+7/-6) |
||||||||
To merge this branch: | bzr merge lp://qastaging/~vexo/bzr-webdav/bzr-webdav | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Wilbur | Approve | ||
Vincent Ladeuil | Needs Fixing | ||
Reagan Sanders (community) | Needs Resubmitting | ||
Review via email: mp+177288@code.qastaging.launchpad.net |
Description of the change
Fixes bugs #1204734 and #1204727 by updating the list of status codes we interpret as success for DELETE operations and explicitly sending Overwrite: T with all MOVE operations, respectively.
To post a comment you must log in.
Thanks for fixing the problems you noticed in bzr-webdav.
The only issue I see is that you forgot to add tests for these bugs that are resolved by your patches. tests/dav_server.py looks like the most likely place to add them. Vincent Ladeuil <email address hidden> would be the authority on the subject as he wrote this plugin.