lxc-android-config

Merge lp://qastaging/~vicamo/lxc-android-config/add-upstart-local-bridge into lp://qastaging/lxc-android-config

  1. add-upstart-local-bridge
  2. Merge into trunk
Proposed by You-Sheng Yang
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 27
Merged at revision: 26
Proposed branch: lp://qastaging/~vicamo/lxc-android-config/add-upstart-local-bridge
Merge into: lp://qastaging/lxc-android-config
Diff against target: 44 lines (+23/-1)
3 files modified
debian/lxc-android-config.service (+2/-1)
lib/systemd/system/force-mtp.service (+10/-0)
lib/systemd/system/upstart-local-bridge.service (+11/-0)
To merge this branch: bzr merge lp://qastaging/~vicamo/lxc-android-config/add-upstart-local-bridge
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Ubuntu Phablet Team Pending
Review via email: mp+307144@code.qastaging.launchpad.net

Commit message

Add systemd upstart-local-bridge service

Description of the change

Add systemd upstart-local-bridge service

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I wonder if we could somehow make this only run when we know that systemd is in use. I don't have much experience here, but will having this bridge run have any influence on systems that do not use systemd? (like our stable vivid-based touch systems)

review: Needs Information
Revision history for this message
You-Sheng Yang (vicamo) wrote :

That's a systemd service file, so this unit surely only run with systemd. To be clear, there is also a lxc-android-config.upstart file under debian/, so upstart-local-bridge already runs in vivid+upstart as part of the android container stack.

lp://qastaging/~vicamo/lxc-android-config/add-upstart-local-bridge updated
26. By You-Sheng Yang

Add systemd force-mtp.service.

27. By You-Sheng Yang

Install force-mtp.service to multi-user.target as well.

Revision history for this message
You-Sheng Yang (vicamo) wrote :

Added missed force-mtp.service. Then eng-build device should automatically start adbd service.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ah, right, even though we do have systemd installed it's not enabled for those (without systemd-sysv). Somehow I had some wrong impression. +1

review: Approve
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Confirmed landed in 0.230+16.04.20161004-0ubuntu1, rootfs rev 51.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches