Merge lp://qastaging/~victor-mireyev/simple-scan/bug-719741 into lp://qastaging/~simple-scan-team/simple-scan/trunk
Proposed by
Victor Mireyev
Status: | Merged |
---|---|
Merged at revision: | 618 |
Proposed branch: | lp://qastaging/~victor-mireyev/simple-scan/bug-719741 |
Merge into: | lp://qastaging/~simple-scan-team/simple-scan/trunk |
Diff against target: |
78 lines (+28/-11) 1 file modified
src/ui.vala (+28/-11) |
To merge this branch: | bzr merge lp://qastaging/~victor-mireyev/simple-scan/bug-719741 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Approve | ||
Review via email: mp+167380@code.qastaging.launchpad.net |
This proposal supersedes a proposal from 2013-05-29.
Description of the change
Fix LP#719741. Save dialog should force file name extensions
To post a comment you must log in.
I don't like how this silently changes the filename as entered - as a user I type in "Blah" but the actual file is "Blah.pdf" etc without any indication this has occurred. I'd prefer a dialog as the GIMP does that suggests the name is changed but allows the user to override this if necessary.
A stray change - not required for the patch but confusing to have it here: file_name. substring (index);
+ extension = default_
Should use C style comments:
+ // Check if file name doesn't have extension
It is confusing calling a callback as a way of updating the extension - you should split out the function from on_file_ type_changed and use it directly. type_changed (selection);
+ on_file_