Merge lp://qastaging/~victored/noise/gapless-playback into lp://qastaging/~elementary-apps/noise/trunk
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~victored/noise/gapless-playback |
| Merge into: | lp://qastaging/~elementary-apps/noise/trunk |
| Diff against target: |
1754 lines (+539/-521) 16 files modified
core/GStreamer/Equalizer.vala (+2/-2) core/GStreamer/Pipeline.vala (+129/-60) core/GStreamer/Playback.vala (+8/-11) core/LibraryWindowInterface.vala (+1/-1) core/Media.vala (+3/-0) core/Player.vala (+27/-3) core/Settings.vala (+2/-2) src/GStreamer/Streamer.vala (+59/-144) src/LibraryWindow.vala (+119/-210) src/LocalBackend/LocalLibrary.vala (+4/-4) src/Objects/MediaKeyListener.vala (+1/-1) src/PlaybackManager.vala (+117/-45) src/Views/ListView/Lists/GenericList.vala (+13/-3) src/Widgets/EqualizerPopover.vala (+2/-2) src/Widgets/InfoPanel.vala (+19/-7) src/Widgets/TopDisplay.vala (+33/-26) |
| To merge this branch: | bzr merge lp://qastaging/~victored/noise/gapless-playback |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| elementary Apps team | Pending | ||
|
Review via email:
|
|||
Description of the change
- Gapless playback implementation will be added soon.
- Required infrastructure changes are being performed at this moment.
- Proposed just to get a diff. Feel free to provide feedback but keep in mind code still needs cleanup.
== BUILD
Configure with 'cmake .. -DBUILD_
== REGRESSIONS
- Fix automatic scrolling to current media and properly refresh list view [GenericList]
- Automatically switch to next media after the previous one ends. This chaining and playback control was part of LibraryWindow. Move it to PlaybackManager and integrate gapless playback.
| Victor Martinez (victored) wrote | # |
Unmerged revisions
- 1805. By Victor Martinez
-
Code cleanup
- 1804. By Victor Martinez
-
Move some functions to Noise.Pipeline to avoid duplicating code in plugins
- 1803. By Victor Martinez
-
correct a few runtime warnings
- 1802. By Victor Martinez
-
reset timeout ID properly after removing source func
- 1801. By Victor Martinez
-
Cleanup & notify when media changes
- 1800. By Victor Martinez
-
Playback: move playback logic and control away from LibraryWindow.vala.
Configure with 'cmake .. -DBUILD_
PLUGINS= OFF' since plugins haven't been updated yet. - 1799. By Victor Martinez
-
Playback: make sure no playback logic code happens on LibraryWindow.
Make wider use of PlaybackManager API. LibraryWindow will be another client of playback manager and will update its widgets accordingly as the playback class notifies status changes have occured.
Gapless playback is kinda broken for MP3/AAC on playbin for GStreamer 1.0. Might want to look into workarounds if we want this feature to ever land any time soon.