Noise

Merge lp://qastaging/~victored/noise/lp-1099591 into lp://qastaging/~elementary-apps/noise/trunk

  1. lp-1099591
  2. Merge into trunk
Proposed by Victor Martinez
Status: Work in progress
Proposed branch: lp://qastaging/~victored/noise/lp-1099591
Merge into: lp://qastaging/~elementary-apps/noise/trunk
Diff against target: 553 lines (+144/-189)
5 files modified
src/CMakeLists.txt (+1/-10)
src/Views/GridView/AlbumListView.vala (+119/-102)
src/Views/GridView/GridLayout.vala (+13/-4)
src/Views/GridView/GridView.vala (+9/-70)
src/Views/ListView/Lists/CellDataFunctionHelper.vala (+2/-3)
To merge this branch: bzr merge lp://qastaging/~victored/noise/lp-1099591
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+210512@code.qastaging.launchpad.net

Commit message

Replace album view popover with a side pane. Fixes lp:1099591

Description of the change

Replace album view popover with a side pane. Fixes lp:1099591

Even though this is a W.I.P., feel free to provide feedback about the code or behavior of the program.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Use Gtk.Revealer for ultra sexy slide-out action ;D

Reply
Revision history for this message
Victor Martinez (victored) wrote :

Nice suggestion :)

Reply
Revision history for this message
Danielle Foré (danrabbit) wrote :

Is it possible to also have a horizontal thin pane between the song list and album artwork? That way, we could resize with the intention to make the list longer (even though it would make the pane thinner as well). I wonder if that might be a good solution for that.

Also, as far as theming, I think I might just get rid of the album view style. It looks like it has an adverse effect on menus and I don't really want to re-implement menu theming there.

Reply
lp://qastaging/~victored/noise/lp-1099591 updated
1564. By Victor Martinez

Improve image scale handling

1565. By Victor Martinez

stop using CSS class "album-list-view"

Revision history for this message
Victor Martinez (victored) wrote :

Agreed. "album-list-view" was giving some problems, so I've removed it. Now there's only a visual glitch that makes the album title and rating use a dark foreground color on a black background haha. I hope you can fix it.

Regarding the vertical ThinPaned, I've somewhat implemented it at lp:~victored/noise/lp-1099591-image-paned, but using it felt awkward, so I didn't push it to this branch. I probably misunderstood your suggestion?

Reply
lp://qastaging/~victored/noise/lp-1099591 updated
1566. By Victor Martinez

style fix

Revision history for this message
Danielle Foré (danrabbit) wrote :

Hrm, no in my head the panes where connected so that adjusting the height also adjusted the width.

Reply
Revision history for this message
Victor Martinez (victored) wrote :

Hmm I don't know how to implement that so that the cover keeps the aspect ratio when resized from either pane.

Now that GTK+ uses height-for-width or width-for-height geometry management, we can only ensure proper aspect ratio when the widget is only resized in one direction (either horizontally or vertically, but not both), meaning that 2 panes are asking GTK+ too much :(

Reply

Unmerged revisions

1566. By Victor Martinez

style fix

1565. By Victor Martinez

stop using CSS class "album-list-view"

1564. By Victor Martinez

Improve image scale handling

1563. By Victor Martinez

Replace album view popover with a sidebar.

This is the (rough) intial revision. Many tweaks are still needed.

1562. By Victor Martinez

update CellDataFunctionHelper.vala to use new Setting singletons

1561. By Victor Martinez

CMake: remove unused workaround GTK_ICON_VIEW_BIG_IS_FIXED since it's no longer used in the source code

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches