Merge lp://qastaging/~victored/noise/lp-1315460 into lp://qastaging/~elementary-apps/noise/trunk

It's also resizing the top and bottom margin, I don't think that it should be the case.

Indeed, I'm not a big fan of that either.

There's a technical limitation though. here 'margin' refers to gtk_icon_view_set_margin, and not gtk_widget_set_margin, so we can't do things like margin_left, margin_top, etc.

See: http://bazaar.launchpad.net/~vcs-imports/gtk/trunk/view/head:/gtk/gtkiconview.c#L5973

A solution could be to have a fixed margin, say 24 px, and only compute the spacing between items. I won't be 'even' spacing anymore, but at least it'd be symmetrical

I've modified the implementation to use a fixed 'margin'. See lp:~victored/noise/album-view-spacing

I'm not sure which one to go with tbh.

Having a fixed outside margin and adjusting spacing between albums sounds solid to me

I've deleted the new 'album-view-spacing' branch and pushed the changes here.

The view currently uses a fixed margin of 24px (top margin appears larger due to item shadow rendering), and only modifies the spacing between items.

Please test again.

This one is better,
To me the row_spacing = ideal_spacing / 2; should be removed

Good call.

I agree only re-flowing horizontally looks better. I modified the default vertical spacing to be 12px instead of the default 6px, which makes the view look cluttered with larger horizontal spacing.

Please test / review again.

Yes, I think it's good like this

Let's go with this then. If you have any suggestions regarding the size of the margin and such, let me know so I can change it.