Audience

Merge lp://qastaging/~vikoadi/audience/private-relayout into lp://qastaging/~audience-members/audience/trunk

  1. private-relayout
  2. Merge into trunk
Proposed by Viko Adi Rahmawan
Status: Rejected
Rejected by: Danielle Foré
Proposed branch: lp://qastaging/~vikoadi/audience/private-relayout
Merge into: lp://qastaging/~audience-members/audience/trunk
Diff against target: 72 lines (+7/-13)
2 files modified
src/Widgets/PlayerPage.vala (+1/-11)
src/Widgets/VideoPlayer.vala (+6/-2)
To merge this branch: bzr merge lp://qastaging/~vikoadi/audience/private-relayout
Reviewer Review Type Date Requested Status
Cody Garver Needs Fixing
Review via email: mp+276349@code.qastaging.launchpad.net

Commit message

make relayout private

Description of the change

make relayout private

relayout by video players's own allocation_changed signal,
 doesnt need playerpage

To post a comment you must log in.
lp://qastaging/~vikoadi/audience/private-relayout updated
551. By Viko Adi Rahmawan

remove comented line

Revision history for this message
Cody Garver (codygarver) wrote :

Needs trunk merged in and conflicts resolved

review: Needs Fixing
Revision history for this message
Danielle Foré (danrabbit) wrote :

Rejecting since it seems to be abandoned

Unmerged revisions

551. By Viko Adi Rahmawan

remove comented line

550. By Viko Adi Rahmawan

video player relayout doesnt need playerpage

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches