Code review comment for lp://qastaging/~vila/bzr/lockable-config-files

Revision history for this message
Andrew Bennetts (spiv) wrote :

Vincent Ladeuil wrote:
> > 305 + @classmethod
> > 306 + def from_bytes(cls, unicode_bytes):
> >
> > It seems a little weird to call it 'unicode_bytes' and to have the function be
> > 'from_bytes'. What about 'from_unicode(cls, unicode_content)' ?
>
> I just went with what spiv proposed.

IIRC, I proposed (or meant to propose) calling that “utf8_bytes”.

-Andrew.

« Back to merge proposal