Merge lp://qastaging/~vila/selenium-simple-test/default-base-url into lp://qastaging/selenium-simple-test
Proposed by
Vincent Ladeuil
| Status: | Merged |
|---|---|
| Approved by: | Corey Goldberg |
| Approved revision: | 402 |
| Merged at revision: | 401 |
| Proposed branch: | lp://qastaging/~vila/selenium-simple-test/default-base-url |
| Merge into: | lp://qastaging/selenium-simple-test |
| Diff against target: |
896 lines (+142/-39) 51 files modified
docs/changelog.rst (+2/-0) src/sst/actions.py (+5/-7) src/sst/selftests/admin_cookies_clear.py (+2/-0) src/sst/selftests/admin_cookies_get.py (+2/-0) src/sst/selftests/admin_load.py (+2/-0) src/sst/selftests/admin_login.py (+2/-0) src/sst/selftests/alerts.py (+2/-0) src/sst/selftests/assert_element.py (+2/-0) src/sst/selftests/assert_text.py (+2/-0) src/sst/selftests/assert_urls.py (+11/-9) src/sst/selftests/attribute.py (+2/-0) src/sst/selftests/button.py (+2/-0) src/sst/selftests/by_css.py (+2/-0) src/sst/selftests/by_xpath.py (+2/-0) src/sst/selftests/checkbox.py (+2/-0) src/sst/selftests/click.py (+2/-0) src/sst/selftests/css_props.py (+2/-0) src/sst/selftests/current_url.py (+8/-7) src/sst/selftests/data_driven_form.py (+2/-1) src/sst/selftests/element_to_string.py (+2/-0) src/sst/selftests/execute_script.py (+2/-0) src/sst/selftests/exists_element.py (+2/-0) src/sst/selftests/file_input.py (+2/-0) src/sst/selftests/get_element.py (+2/-0) src/sst/selftests/get_element_fails.py (+2/-0) src/sst/selftests/get_element_text_regex.py (+2/-0) src/sst/selftests/go_browser.py (+2/-0) src/sst/selftests/html5.py (+5/-4) src/sst/selftests/is_displayed.py (+2/-0) src/sst/selftests/keys.py (+2/-0) src/sst/selftests/link.py (+2/-0) src/sst/selftests/no_js.py (+2/-0) src/sst/selftests/radio.py (+2/-0) src/sst/selftests/refresh.py (+2/-0) src/sst/selftests/save_page_source.py (+2/-0) src/sst/selftests/select.py (+2/-0) src/sst/selftests/source.py (+2/-0) src/sst/selftests/switch_to_frame.py (+2/-0) src/sst/selftests/switch_to_window.py (+2/-0) src/sst/selftests/tables.py (+2/-0) src/sst/selftests/take_screenshot.py (+2/-0) src/sst/selftests/test_get_text.py (+2/-0) src/sst/selftests/text.py (+2/-0) src/sst/selftests/textfield.py (+2/-0) src/sst/selftests/title.py (+15/-11) src/sst/selftests/unicode.py (+2/-0) src/sst/selftests/waitfor.py (+2/-0) src/sst/selftests/window_close.py (+2/-0) src/sst/selftests/window_size.py (+2/-0) src/sst/selftests/yui.py (+2/-0) src/sst/tests/test_actions.py (+8/-0) |
| To merge this branch: | bzr merge lp://qastaging/~vila/selenium-simple-test/default-base-url |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Corey Goldberg (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Set BASE_URL default value to None fixing the leak from sst own test server.
Description of the change
As discussed on IRC, this use a None default value for BASE_URL and displays an appropriate error message hinting that set_base_url should be called.
The check is done in _fix_url which is the only place where BASE_URL needs to be set. It's called by go_to and assert_url, I used the former to add a test.
To post a comment you must log in.
Revision history for this message
| Vincent Ladeuil (vila) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
there seems to be some extra imports added in many of the scripted acceptance tests? are these needed?
for example,
in `selftests/
you added: "import sst", so the file starts with:
import sst
import sst.actions
only sst.actions is used (nothing from the root sst namespace).
actually, either import would do the job here, so we don't need both.
besides that, +1 on this MP