Merge lp://qastaging/~vila/selenium-simple-test/even-less-flakes into lp://qastaging/selenium-simple-test

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 391
Merged at revision: 391
Proposed branch: lp://qastaging/~vila/selenium-simple-test/even-less-flakes
Merge into: lp://qastaging/selenium-simple-test
Prerequisite: lp://qastaging/~elopio/selenium-simple-test/last_flake
Diff against target: 290 lines (+44/-37)
15 files modified
ci.sh (+1/-2)
src/sst/actions.py (+3/-3)
src/sst/junitxmlrunner.py (+9/-9)
src/sst/runtests.py (+1/-2)
src/sst/scripts/run.py (+3/-3)
src/sst/selftests/attribute.py (+1/-1)
src/sst/selftests/data_driven_form.py (+14/-5)
src/sst/selftests/shared/helpers.py (+1/-1)
src/sst/selftests/unicode.py (+1/-1)
src/sst/tests/test_django_devserver.py (+1/-1)
src/sst/tests/test_html_runner.py (+4/-4)
src/sst/tests/test_runtests_find_cases.py (+1/-1)
src/sst/tests/test_selftest.py (+2/-2)
src/testproject/simple/urls.py (+1/-1)
src/testproject/urls.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~vila/selenium-simple-test/even-less-flakes
Reviewer Review Type Date Requested Status
Corey Goldberg (community) Approve
Review via email: mp+160330@code.qastaging.launchpad.net

Commit message

Enable flake8 warnings and fix them.

Description of the change

Built on top of Leo's branch, this goes one step further and let flake8 display the warnings.

There is only one controversial warning here really in data_driven_form.py. flake8 won't ever be able to understand how the magic symbols are injected so I explicitly declare them.

To post a comment you must log in.
Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches