Merge lp://qastaging/~vila/selenium-simple-test/flake8 into lp://qastaging/selenium-simple-test

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Leo Arias
Approved revision: 405
Merged at revision: 406
Proposed branch: lp://qastaging/~vila/selenium-simple-test/flake8
Merge into: lp://qastaging/selenium-simple-test
Diff against target: 40 lines (+2/-4)
2 files modified
src/sst/cases.py (+0/-1)
src/sst/tests/test_result.py (+2/-3)
To merge this branch: bzr merge lp://qastaging/~vila/selenium-simple-test/flake8
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Review via email: mp+163858@code.qastaging.launchpad.net

Commit message

Fix flake8 warnings.

Description of the change

This fixes the flake8 warnings that are caught only by ./ci.sh --flake8 but not by the test_pep8_conformance test :-/

IMHO, we should get rid of ./ci.sh --flake8 or update test_pep8_conformance to do the same checks or add ./ci.sh --flake8 to the pre-merge checks.

Having https://jenkins.ubuntone.info/job/u1-qa-sst-trunk-firefox-next fails after the merge have been accepted is just making false positives too easy to trigger.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches