Merge lp://qastaging/~vila/selenium-simple-test/separate-sst-test into lp://qastaging/selenium-simple-test

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 410
Merged at revision: 415
Proposed branch: lp://qastaging/~vila/selenium-simple-test/separate-sst-test
Merge into: lp://qastaging/selenium-simple-test
Diff against target: 521 lines (+183/-127)
11 files modified
ci.sh (+1/-1)
docs/index.rst (+11/-14)
setup.py (+1/-0)
src/sst/cases.py (+6/-2)
src/sst/command.py (+0/-15)
src/sst/runtests.py (+4/-11)
src/sst/scripts/run.py (+0/-76)
src/sst/scripts/test.py (+136/-0)
src/sst/tests/test_django_devserver.py (+5/-5)
sst-test (+15/-0)
test-loader.TODO (+4/-3)
To merge this branch: bzr merge lp://qastaging/~vila/selenium-simple-test/separate-sst-test
Reviewer Review Type Date Requested Status
Corey Goldberg (community) Approve
Review via email: mp+166693@code.qastaging.launchpad.net

Commit message

Separate sst-test out of sst-run to have a clearer runtests() implementation.

Description of the change

This creates a separate command to run sst selftests to get rid of the XXX in runtests().

This has a fallout around the handling of the results directory that I'd like to address in a followup proposal to keep mps reviewable while making runtests() easier to test too.

To post a comment you must log in.
Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches