Merge lp://qastaging/~vila/selenium-simple-test/test-loader into lp://qastaging/selenium-simple-test

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 463
Merged at revision: 418
Proposed branch: lp://qastaging/~vila/selenium-simple-test/test-loader
Merge into: lp://qastaging/selenium-simple-test
Diff against target: 1483 lines (+470/-754)
9 files modified
src/sst/filters.py (+3/-3)
src/sst/loader.py (+131/-286)
src/sst/result.py (+0/-3)
src/sst/runtests.py (+10/-17)
src/sst/selftests/shared/__init__.py (+3/-0)
src/sst/tests/test_filters.py (+1/-2)
src/sst/tests/test_loader.py (+272/-413)
src/sst/tests/test_runtests.py (+50/-1)
test-loader.TODO (+0/-29)
To merge this branch: bzr merge lp://qastaging/~vila/selenium-simple-test/test-loader
Reviewer Review Type Date Requested Status
Corey Goldberg (community) Approve
Leo Arias (community) code review Approve
Review via email: mp+167562@code.qastaging.launchpad.net

Commit message

Simplify test loader implementation.

Description of the change

This simplify the new loader implementation, splitting between the part that may be upstreamed and the sst specific parts.

All existing tests have been migrated and some more added.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

I can't find any errors. But this is huge, I've asked for another pair of eyes to double check :)

review: Approve (code review)
Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

lgtm too

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches