Merge lp://qastaging/~vila/selenium-simple-test/trunk into lp://qastaging/selenium-simple-test

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 420
Merged at revision: 420
Proposed branch: lp://qastaging/~vila/selenium-simple-test/trunk
Merge into: lp://qastaging/selenium-simple-test
Diff against target: 25 lines (+3/-5)
1 file modified
src/sst/tests/test_result.py (+3/-5)
To merge this branch: bzr merge lp://qastaging/~vila/selenium-simple-test/trunk
Reviewer Review Type Date Requested Status
Corey Goldberg (community) Approve
Review via email: mp+170250@code.qastaging.launchpad.net

Commit message

Avoid test failure by simplifying test_fail leading to a simpler traceback, easier to control

Description of the change

Better fix for the result test failure.

The fix designed with Corey led to
https://jenkins.ubuntone.info/job/u1-qa-sst-trunk-firefox-next/60/testReport/sst.tests.test_result/TestXmlOutput/test_fail_output/

The root cause is that something changed in the way testtools reports the traceback which involves displaying files from unittest itself. In turn, this introduces a hard dependency to a precise python version.

The fix is to completely avoid involving testtools in the traceback by
raising directly from the test.

To post a comment you must log in.
Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches