Ubuntu CI Services

Merge lp://qastaging/~vila/ubuntu-ci-services-itself/1293625-no-built-binaries into lp://qastaging/ubuntu-ci-services-itself

  1. 1293625-no-built-binaries
  2. Merge into trunk
Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 414
Merged at revision: 413
Proposed branch: lp://qastaging/~vila/ubuntu-ci-services-itself/1293625-no-built-binaries
Merge into: lp://qastaging/ubuntu-ci-services-itself
Diff against target: 57 lines (+14/-10)
2 files modified
TRICKS (+2/-0)
test_runner/run_test.py (+12/-10)
To merge this branch: bzr merge lp://qastaging/~vila/ubuntu-ci-services-itself/1293625-no-built-binaries
Reviewer Review Type Date Requested Status
Paul Larson Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+212267@code.qastaging.launchpad.net

Commit message

Fix the adt-run call to not build binaries unless required.

Description of the change

Re-digging adt-run and testing locally (yeah throw away vms from uci-vms !)
I found the right combination of options.

I did a few more tests and this combination is still obeying 'Restrictions:
build-needed' and still installing the test deps when needed but don't
rebuild the package.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:414
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~vila/ubuntu-ci-services-itself/1293625-no-built-binaries/+merge/212267/+edit-commit-message

http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/456/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/456/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:414
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/458/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/458/rebuild

review: Approve (continuous-integration)
Revision history for this message
Paul Larson (pwlars) wrote :

Makes sense, which packages did you try running this with? Would feel more comfortable knowing it was tried with some package that normally has to be compiled, but doesn't request it in the restrictions to see that 1. it doesn't compile it, and 2. the tests still pass since the binary package is installed. Otherwise, +1

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

> Makes sense, which packages did you try running this with?

libpng

This package requires that *some* test deps are compiled but not the package library itself.

> Would feel more
> comfortable knowing it was tried with some package that normally has to be
> compiled, but doesn't request it in the restrictions to see

'has to be compiled'is a configuration that should not exist. It would mean the package is not testing the installed version which is what dep-8 tests are about.

> that 1. it doesn't
> compile it, and 2. the tests still pass since the binary package is installed.

But *that* is what I tested, test passing despite not compiling the package.

> Otherwise, +1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches