Pithos

Merge lp://qastaging/~vinod-khare/pithos/appindicator into lp://qastaging/~kevin-mehall/pithos/trunk

appindicator
Merge into trunk

Proposed by Vinod Khare on 2010-07-22

Status:	Superseded
Proposed branch:	lp://qastaging/~vinod-khare/pithos/appindicator
Merge into:	lp://qastaging/~kevin-mehall/pithos/trunk
Diff against target:	303 lines (+129/-9) 4 files modified bin/PithosAppIndicator.py (+58/-0) bin/pithos (+10/-2) pithos/notification_icon.py (+58/-7) pithos/pithosconfig.py (+3/-0)
To merge this branch:	bzr merge lp://qastaging/~vinod-khare/pithos/appindicator
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Kevin Mehall		2010-07-22	Needs Resubmitting on 2010-07-22
Review via email: mp+30720@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2010-07-22.

Description of the change

Adds appindicator support for Ubuntu. Also adds a monochrome icon for the same.

Revision history for this message

Kevin Mehall (kevin-mehall) wrote on 2010-07-22:

Can this share any code with the recently-merged notification area icon patch? Sorry to merge that just as you were about to submit...

See http://bazaar.launchpad.net/~gtg/gtg/trunk/annotate/head:/GTG/plugins/notification_area/notification_area.py
for an example of a notification area plugin that combines appindicator and the legacy notification area

Then it can use the same enable/disable mechanism I implemented for the existing icon.

Also, it looks like this branch sets the execute bit on every file in the repository. Is there anything you can do about this?

review: Needs Resubmitting

Revision history for this message

Vinod Khare (vinod-khare) wrote on 2010-07-22:

> Can this share any code with the recently-merged notification area icon patch?
> Sorry to merge that just as you were about to submit...
>
> See http://bazaar.launchpad.net/~gtg/gtg/trunk/annotate/head:/GTG/plugins/noti
> fication_area/notification_area.py
> for an example of a notification area plugin that combines appindicator and
> the legacy notification area
>
> Then it can use the same enable/disable mechanism I implemented for the
> existing icon.
>
> Also, it looks like this branch sets the execute bit on every file in the
> repository. Is there anything you can do about this?

Yeah, just saw the merge, I'm pulling the changes to see if I can merge the two things.

lp://qastaging/~vinod-khare/pithos/appindicator updated on 2010-07-22

69. By Vinod Khare <email address hidden> on 2010-07-22: Merging appindicator with notification area icon
70. By Vinod Khare <email address hidden> on 2010-07-22: This will hopefully resolve the execute bit problem :(
71. By Vinod Khare <email address hidden> on 2010-07-22: Code cleanup