Merge lp://qastaging/~vishalbhoj/linaro-android-build-tools/fix-kernel-source-variable into lp://qastaging/linaro-android-build-tools

Proposed by vishal
Status: Merged
Approved by: Milo Casagrande
Approved revision: 682
Merged at revision: 687
Proposed branch: lp://qastaging/~vishalbhoj/linaro-android-build-tools/fix-kernel-source-variable
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 17 lines (+6/-0)
1 file modified
build-scripts/create-user-build-script (+6/-0)
To merge this branch: bzr merge lp://qastaging/~vishalbhoj/linaro-android-build-tools/fix-kernel-source-variable
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+194992@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Hi Vishal,

 export MANIFEST_BRANCH=${MANIFEST_BRANCH}
 export MANIFEST_FILENAME=${MANIFEST_FILENAME}
 export TARGET_PRODUCT=${TARGET_PRODUCT}
+EOF
+if [ -n "$TARGET_KERNEL_SOURCE" ] ; then
+ cat <<EOF
 export TARGET_KERNEL_SOURCE=${TARGET_KERNEL_SOURCE}
+EOF
+ cat <<EOF

I think here you are missing an "fi" line to close the previous "if".
Looking at the entire script, after this "if" statement there is another one, but this one is not closed.

 export TARGET_SIMULATOR=false
 export BUILD_TINY_ANDROID=${BUILD_TINY_ANDROID}

review: Needs Fixing
682. By vishal

Fix the missing fi condition and fix the indentation

Revision history for this message
vishal (vishalbhoj) wrote :

Thanks Milo,

I have fixed this missing fi.

Revision history for this message
Milo Casagrande (milo) wrote :

As said on IRC, will merge and fix the "fi" statement that is on the wrong line now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches