Merge lp://qastaging/~vishalbhoj/linaro-image-tools/hwpack-from-boottarball into lp://qastaging/linaro-image-tools/11.11

Proposed by vishal
Status: Merged
Merged at revision: 603
Proposed branch: lp://qastaging/~vishalbhoj/linaro-image-tools/hwpack-from-boottarball
Merge into: lp://qastaging/linaro-image-tools/11.11
Diff against target: 17 lines (+7/-0)
1 file modified
linaro-android-media-create (+7/-0)
To merge this branch: bzr merge lp://qastaging/~vishalbhoj/linaro-image-tools/hwpack-from-boottarball
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Needs Fixing
Review via email: mp+144305@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Will /boot/config perhaps conflict with something other than the "hwpack"? Also, it'd be good to have tests for this to ensure it works properly and that we don't break it in the future.

Revision history for this message
Milo Casagrande (milo) wrote :

Hi Vishal,

overall it looks good.

Looking at the code, I was thinking about where the boot tarball hwpack will be picked up. As it has been implemented now, the hwpack from the boot tarball will take priority, even if we pass one on the command line. What if someone wants to test different hwpack values, but using the same tarballs? Would it make sense to check for the hwpack in the boot tarball before using the one passed on the command line? It is not mandatory, it works also in this way, and if it is OK for you it is not a problem.

Testing that part might be trickier than expected actually: the file is not usuable as a module, so we cannot test parts and bits of it.

We might add a check in the 'linaro_image_tools/utils.py' file under the 'additionl_android_option_checks' function, adding some logic there. In that way, we can easily test that function, as we are already doing: the tests are located in 'linaro_image_tools/tests/test_utils.py'. It might be also necessary to add a new function to the 'utils.py' module, just to check the path in order to make it testable.

If you need any help to move this forward, please feel free to ping me on IRC.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches