Linaro Image Tools

Merge lp://qastaging/~vishalbhoj/linaro-image-tools/increase-system-partition-size into lp://qastaging/linaro-image-tools/11.11

increase-system-partition-size
Merge into trunk

Proposed by vishal on 2013-11-28

Status:	Merged
Approved by:	Milo Casagrande on 2013-11-29
Approved revision:	647
Merged at revision:	646
Proposed branch:	lp://qastaging/~vishalbhoj/linaro-image-tools/increase-system-partition-size
Merge into:	lp://qastaging/linaro-image-tools/11.11
Diff against target:	77 lines (+16/-16) 2 files modified linaro_image_tools/media_create/android_boards.py (+2/-2) linaro_image_tools/media_create/tests/test_media_create.py (+14/-14)
To merge this branch:	bzr merge lp://qastaging/~vishalbhoj/linaro-image-tools/increase-system-partition-size
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Milo Casagrande (community)		2013-11-28	Approve on 2013-11-29
Review via email: mp+197026@code.qastaging.launchpad.net

Revision history for this message

Milo Casagrande (milo) wrote on 2013-11-28:

Hi Vishal,

I'm fine with the change, just one question: why exactly 768? Doubling the previous value (512) would be too big?
Also, before we can merge, please update the tests: with this change at least 7 are failing.

Thanks.

review: Needs Fixing

lp://qastaging/~vishalbhoj/linaro-image-tools/increase-system-partition-size updated on 2013-11-29

647. By vishal on 2013-11-29: Update the tests wrt to the latest changes in system partition size for Android

Revision history for this message

vishal (vishalbhoj) wrote on 2013-11-29:

Doubling the previous value is no an option because fitting all the partition in a 2 GB sdcard would be difficult. Currently I have cut 256 MB from sdcard partition and added it to sytem partition. Also fixed the tests in commit 647.

Revision history for this message

Milo Casagrande (milo) wrote on 2013-11-29:

Thanks Vishal, looks good now.

review: Approve