Drizzle

Merge lp://qastaging/~vjsamuel/drizzle/encapsulate-join-read-const-table into lp://qastaging/drizzle/7.0

encapsulate-join-read-const-table
Merge into 7.0

Proposed by Vijay Samuel on 2011-02-04

Status:	Merged
Approved by:	Brian Aker on 2011-02-05
Approved revision:	2144
Merged at revision:	2147
Proposed branch:	lp://qastaging/~vjsamuel/drizzle/encapsulate-join-read-const-table
Merge into:	lp://qastaging/drizzle/7.0
Diff against target:	524 lines (+118/-114) 11 files modified drizzled/create_field.h (+0/-1) drizzled/join.cc (+11/-12) drizzled/join_table.cc (+79/-0) drizzled/join_table.h (+7/-3) drizzled/nested_join.h (+3/-2) drizzled/optimizer/position.h (+1/-1) drizzled/sql_parse.cc (+7/-7) drizzled/sql_select.cc (+2/-79) drizzled/sql_select.h (+2/-2) drizzled/table_list.cc (+2/-2) drizzled/table_list.h (+4/-5)
To merge this branch:	bzr merge lp://qastaging/~vjsamuel/drizzle/encapsulate-join-read-const-table
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Vijay Samuel		Pending
Monty Taylor	2011-02-04	Pending
Brian Aker	2011-02-04	Pending
Review via email: mp+48655@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-02-04.

Revision history for this message

Monty Taylor (mordred) wrote on 2011-02-04: Posted in a previous version of this proposal

Gave vijay a few notes on IRC.

11:12 <mtaylor> vjsamuel: in join_table.h - you added this:
11:12 <mtaylor> vjsamuel: + int join_read_const_table(optimizer::Position *);
11:12 <vjsamuel> mtaylor: yes.
11:12 <mtaylor> vjsamuel: could you add a name to that param?
11:13 <mtaylor> vjsamuel: even just int join_read_const_table(optimizer::Position *pos); would be nice
11:14 <vjsamuel> mtaylor: ok. will do. will update it and change the function name to joinReadConstTable
11:14 <mtaylor> vjsamuel: also, if you change nested_join_st from struct to class, please rename it as well (_st suffix means "this is a struct" to me)
11:14 <mtaylor> vjsamuel: other than that - your branch looks good