Software Updater

Merge lp://qastaging/~vorlon/update-manager/ubuntu-support-optimize into lp://qastaging/update-manager

ubuntu-support-optimize
Merge into main

Proposed by Steve Langasek on 2017-04-28

Status:	Merged
Merged at revision:	2762
Proposed branch:	lp://qastaging/~vorlon/update-manager/ubuntu-support-optimize
Merge into:	lp://qastaging/update-manager
Diff against target:	135 lines (+45/-24) 3 files modified debian/changelog (+9/-0) debian/control (+1/-0) ubuntu-support-status (+35/-24)
To merge this branch:	bzr merge lp://qastaging/~vorlon/update-manager/ubuntu-support-optimize
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Brian Murray		2017-04-28	Approve on 2017-04-28
Review via email: mp+323363@code.qastaging.launchpad.net

Revision history for this message

Brian Murray (brian-murray) wrote on 2017-04-28:

I'd guess this is going into artful in which case you'd want the version number to be 1:17.10.1. I've added some comments in-line.

Is there something that calls ubuntu-support-staus? If it used regularly then maybe the release_date should be cached somewhere.

review: Needs Fixing

Revision history for this message

Steve Langasek (vorlon) wrote on 2017-04-28:

> Is there something that calls ubuntu-support-status? If it used regularly then
> maybe the release_date should be cached somewhere.

It is not, this is an admin-facing tool. I don't think we need to cache anything beyond just leveraging distro-data; reading the csv file once per invocation is cheap (especially when compared to looking up a releases file once per package!).

Revision history for this message

Brian Murray (brian-murray) wrote on 2017-04-28:

Okay, I was thinking about hwe-support-status which is used by update-notifier.

lp://qastaging/~vorlon/update-manager/ubuntu-support-optimize updated on 2017-04-28

2764. By Steve Langasek on 2017-04-28: sort(ish) the imports
2765. By Steve Langasek on 2017-04-28: in all cases where we can't find a valid Ubuntu release date, throw an error
2766. By Steve Langasek on 2017-04-28: fix changelog version